Skip to content

[3.8] bpo-34155: Dont parse domains containing @ (GH-13079) #14824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2019
Merged

[3.8] bpo-34155: Dont parse domains containing @ (GH-13079) #14824

merged 1 commit into from
Aug 9, 2019

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 17, 2019 •
edited by bedevere-bot
Loading

Before:

    >>> email.message_from_string('From: a@malicious.org@important.com', policy=email.policy.default)['from'].addresses
    (Address(display_name='', username='a', domain='malicious.org'),)

    >>> parseaddr('a@malicious.org@important.com')
    ('', 'a@malicious.org')

After:

    >>> email.message_from_string('From: a@malicious.org@important.com', policy=email.policy.default)['from'].addresses
    (Address(display_name='', username='', domain=''),)

    >>> parseaddr('a@malicious.org@important.com')
    ('', 'a@')

https://bugs.python.org/issue34155
(cherry picked from commit 8cb65d1)

Co-authored-by: jpic jpic@users.noreply.github.com

https://bugs.python.org/issue34155

@jpic @miss-islington
bpo-34155: Dont parse domains containing @ (pythonGH-13079)
67b52ff 
Before:

        >>> email.message_from_string('From: a@malicious.org@important.com', policy=email.policy.default)['from'].addresses
        (Address(display_name='', username='a', domain='malicious.org'),)

        >>> parseaddr('a@malicious.org@important.com')
        ('', 'a@malicious.org')

    After:

        >>> email.message_from_string('From: a@malicious.org@important.com', policy=email.policy.default)['from'].addresses
        (Address(display_name='', username='', domain=''),)

        >>> parseaddr('a@malicious.org@important.com')
        ('', 'a@')

https://bugs.python.org/issue34155
(cherry picked from commit 8cb65d1)

Co-authored-by: jpic <jpic@users.noreply.github.com>
@miss-islington miss-islington requested a review from a team as a code owner July 17, 2019 21:54
@bedevere-bot bedevere-bot mentioned this pull request Jul 17, 2019
Merged
@miss-islington
Copy link
Contributor Author

@jpic: Status check is done, and it's a success ✅ .

2 similar comments
@miss-islington
Copy link
Contributor Author

@jpic: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@jpic: Status check is done, and it's a success ✅ .

maxking
maxking approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@maxking maxking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington miss-islington merged commit 2170774 into python:3.8 Aug 9, 2019
@miss-islington miss-islington deleted the backport-8cb65d1-3.8 branch August 9, 2019 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxking maxking maxking approved these changes

Assignees
No one assigned
Labels
type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @maxking @the-knights-who-say-ni @bedevere-bot @jpic