Skip to content

Adjust zip() docstring #14833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2019
Merged

Adjust zip() docstring #14833

merged 1 commit into from
Jul 18, 2019

Conversation

sir-sigurd
Copy link
Contributor

zip() can be called without any arguments

@sir-sigurd
Adjust zip() docstring
c4a2e06 
zip() can be called without any arguments
tirkarthi
tirkarthi approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Docs Doc/library/functions.rst already use it. Thanks.

@tirkarthi
Copy link
Member

cc: @rhettinger

@brettcannon brettcannon merged commit af2f5b1 into python:master Jul 18, 2019
@brettcannon
Copy link
Member

Thanks!

@sir-sigurd sir-sigurd deleted the zip-docstring branch July 18, 2019 18:20
@tirkarthi
Copy link
Member

Brett, can this be backported to 3.8 and 3.7? Even 2.7 has similar docstring that could be updated.

cpython/Python/bltinmodule.c

Line 2619 in 46c2eff

"zip(seq1 [, seq2 [...]]) -> [(seq1[0], seq2[0] ...), (...)]\n\

Thanks

@brettcannon
Copy link
Member

@tirkarthi I'm a bit hesitant just because you never know who's parsing this stuff and it's a minor change that doesn't correct bad information, it just makes it easier to read. If another core dev wants to do the backport I won't object, though.

@brettcannon
Copy link
Member

@tirkarthi Actually, I take that back as it does fix the zip() doc issue, so I will backport for 3.7 and 3.8.

@miss-islington
Copy link
Contributor

Thanks @sir-sigurd for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @sir-sigurd for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-14865 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-14866 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2019
@sir-sigurd @miss-islington
Adjust builtins.zip() docstring to better communicate its signature (p…
4a2e2c8 
…ythonGH-14833)

(cherry picked from commit af2f5b1)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2019
@sir-sigurd @miss-islington
Adjust builtins.zip() docstring to better communicate its signature (p…
946f2a8 
…ythonGH-14833)

(cherry picked from commit af2f5b1)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
miss-islington added a commit that referenced this pull request Jul 19, 2019
@miss-islington @sir-sigurd
Adjust builtins.zip() docstring to better communicate its signature (G…
843fd85 
…H-14833)

(cherry picked from commit af2f5b1)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
miss-islington added a commit that referenced this pull request Jul 19, 2019
@miss-islington @sir-sigurd
Adjust builtins.zip() docstring to better communicate its signature (G…
3015191 
…H-14833)

(cherry picked from commit af2f5b1)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
@tirkarthi
Copy link
Member

Thanks Brett :)

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@sir-sigurd @lisroach
Adjust builtins.zip() docstring to better communicate its signature (p…
01dd9f8 
…ythonGH-14833)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@sir-sigurd @DinoV
Adjust builtins.zip() docstring to better communicate its signature (p…
7dad614 
…ythonGH-14833)
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@sir-sigurd @websurfer5
Adjust builtins.zip() docstring to better communicate its signature (p…
d03145b 
…ythonGH-14833)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@tirkarthi tirkarthi tirkarthi approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sir-sigurd @tirkarthi @brettcannon @miss-islington @bedevere-bot @the-knights-who-say-ni