Skip to content

bpo-37444: Update differing exception between builtins and importlib #14869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 3, 2019
Merged

bpo-37444: Update differing exception between builtins and importlib #14869

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
314b4a4
bpo-37444: Update differing exception between builtins and importlib
nsiregar Jul 20, 2019
223ce2d
Update documentation for resolve_name
nsiregar Jul 23, 2019
027dce0
Updated correct spelling and inline markup
nsiregar Jul 28, 2019
8455d7f
Update versionchanged note for importlib doc
nsiregar Jul 29, 2019
375dd4f
Tweak wordiing on versionchanged note
ncoghlan Jul 30, 2019
8fa4256
Note the porting issue in What's New
ncoghlan Jul 30, 2019
d450331
Markup fix
ncoghlan Jul 30, 2019
bf5bc8c
Add a mention of the change to builtins.__import__ no longer raising …
brettcannon Aug 2, 2019
fca53f9
Add missing parameter markup
brettcannon Aug 2, 2019
b0c8536
Fix whatsnew documentation
nsiregar Aug 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update documentation for resolve_name
  • Loading branch information
@nsiregar
nsiregar committed Jul 23, 2019
commit 223ce2d07a66f46e50c7d21167b10032a0c4f67e
2 changes: 1 addition & 1 deletion Doc/library/importlib.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1433,7 +1433,7 @@ an :term:`importer`.
``importlib.util.resolve_name('sys', __package__)`` without doing a
check to see if the **package** argument is needed.

:exc:`ValueError` is raised if **name** is a relative module name but
:exc:`ImportError` is raised if **name** is a relative module name but
package is a false value (e.g. ``None`` or the empty string).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
package is a false value (e.g. ``None`` or the empty string).
**package** is a false value (e.g. ``None`` or the empty string).

:exc:`ValueError` is also raised a relative name would escape its containing
package (e.g. requesting ``..bacon`` from within the ``spam`` package).
Expand Down