-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
Fix typos in comments, docs and test names #15018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Travis failure had something to do with checksum and clinic. Error in file "./Modules/posixmodule.c" on line 14543: My guess is that it has to do with correction of The Appveyor build succeeded, the tests failed with
The correction of The same comment applies to all 4 Pipelines failures. I will make this change and trigger a retest to see if this is the correct adjustment. |
account for change in string length
|
Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu>
Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu>
Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu>
On my Windows machine, I ran the command Petr Viktorin suggested to fix the Travis failure (with |
@minho42 @aeros167 There is again the question of backports. Kyle, are you willing to try it again, or should I do the idlelib changes separately. (I read elsewhere that you would be doing other stuff for awhile.) To do backports, it would have been better to have run the spell checking on 3.8 and 3.7 branches also and used the results to submit 3 separate PRs, one for master only, once for master + 3.8, and one for all 3. |
@terryjreedy I'm currently out of town on vacation without access to any development utilities (otherwise I'd end up spending the whole vacation reviewing PRs, haha). I'm still responding to any comments directly addressed to me and emails, but I won't be able to submit anything new. I can look into backporting the changes in about a couple of weeks when I'm back at home, but you could probably do the idle fixes separately in the meantime. Thanks for mentioning me. The other stuff I've been working on has mostly involved the devguide, specifically with writing sections for the new Python triage team (on github, not exclusively bpo as it was before) and making changes to the experts index. I don't mind helping with this as well once I'm back home, I'll be on break for a few weeks between semesters until the 25th so I'll have plenty of time for Python contributions (: |
Idlelib typos in #15029. Will delete them here. |
@aeros167 3.8.0b3 released yesterday. b4 is due 8/26, 3.7.5 late Sept. I will merge this when CI passes and you can do whatever whenever. Take a break and enjoy yourself in the meanwhile. |
@terryjreedy: Please replace |
Thanks. |
* Fix typos in comments, docs and test names * Update test_pyparse.py account for change in string length * Apply suggestion: splitable -> splittable Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu> * Apply suggestion: splitable -> splittable Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu> * Apply suggestion: Dealloccte -> Deallocate Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu> * Update posixmodule checksum. * Reverse idlelib changes.
* Fix typos in comments, docs and test names * Update test_pyparse.py account for change in string length * Apply suggestion: splitable -> splittable Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu> * Apply suggestion: splitable -> splittable Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu> * Apply suggestion: Dealloccte -> Deallocate Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu> * Update posixmodule checksum. * Reverse idlelib changes.
* Fix typos in comments, docs and test names * Update test_pyparse.py account for change in string length * Apply suggestion: splitable -> splittable Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu> * Apply suggestion: splitable -> splittable Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu> * Apply suggestion: Dealloccte -> Deallocate Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu> * Update posixmodule checksum. * Reverse idlelib changes.
No description provided.