Skip to content

Fix typos in comments, docs and test names #15018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 30, 2019
Merged

Fix typos in comments, docs and test names #15018

merged 8 commits into from
Jul 30, 2019

Conversation

minho42
Copy link
Contributor

@minho42 minho42 commented Jul 30, 2019

No description provided.

@terryjreedy
Copy link
Member

terryjreedy commented Jul 30, 2019

Travis failure had something to do with checksum and clinic.

Error in file "./Modules/posixmodule.c" on line 14543:
Checksum mismatch!
Expected: b3ae8afd275ea5cd
Computed: 1e001c855e011720
Suggested fix: remove all generated code including the end marker,
or use the '-f' option.
Makefile:573: recipe for target 'clinic' failed
make: *** [clinic] Error 255

My guess is that it has to do with correction of identifiedy to identified on line 2820 of posixmodule.c.h and a need to regenerate something after the fix. Someone else who knows more will have to deal with this.

The Appveyor build succeeded, the tests failed with

FAIL: test_study2 (idlelib.idle_test.test_pyparse.PyParseTest) (string="'''This is a multiline continuation docstring.\n\n")

Traceback (most recent call last):
  File "C:\projects\cpython\lib\idlelib\idle_test\test_pyparse.py", line 252, in test_study2
    eq(p.stmt_end, test.end)
AssertionError: 48 != 49

The correction of continutation to continuation on line 209 shorted the string from 49 to 48, so on the next line which has 0, 49, "'", None, ((0, 0), (0, 1), (49, 0))),, 49 has to be changed to 48 twice.

The same comment applies to all 4 Pipelines failures. I will make this change and trigger a retest to see if this is the correct adjustment.

account for change in string length
@encukou
Copy link
Member

encukou commented Jul 30, 2019

need to regenerate something after the fix

Tools/clinic/clinic.py -f ./Modules/posixmodule.c should regenerate that.

minho42 and others added 5 commits July 31, 2019 01:11
@terryjreedy
Copy link
Member

On my Windows machine, I ran the command Petr Viktorin suggested to fix the Travis failure (with python prepended) and committed and pushed the result. There was some fiddy note about line ending and regenerating git index, but the diff looks right in relation to the failure message. We'll see.

@terryjreedy
Copy link
Member

@minho42 @aeros167 There is again the question of backports. Kyle, are you willing to try it again, or should I do the idlelib changes separately. (I read elsewhere that you would be doing other stuff for awhile.)

To do backports, it would have been better to have run the spell checking on 3.8 and 3.7 branches also and used the results to submit 3 separate PRs, one for master only, once for master + 3.8, and one for all 3.

@aeros
Copy link
Contributor

aeros commented Jul 30, 2019

@terryjreedy I'm currently out of town on vacation without access to any development utilities (otherwise I'd end up spending the whole vacation reviewing PRs, haha). I'm still responding to any comments directly addressed to me and emails, but I won't be able to submit anything new.

I can look into backporting the changes in about a couple of weeks when I'm back at home, but you could probably do the idle fixes separately in the meantime. Thanks for mentioning me.

The other stuff I've been working on has mostly involved the devguide, specifically with writing sections for the new Python triage team (on github, not exclusively bpo as it was before) and making changes to the experts index.

I don't mind helping with this as well once I'm back home, I'll be on break for a few weeks between semesters until the 25th so I'll have plenty of time for Python contributions (:

@terryjreedy
Copy link
Member

Idlelib typos in #15029. Will delete them here.

@terryjreedy
Copy link
Member

@aeros167 3.8.0b3 released yesterday. b4 is due 8/26, 3.7.5 late Sept. I will merge this when CI passes and you can do whatever whenever. Take a break and enjoy yourself in the meanwhile.

@terryjreedy terryjreedy merged commit c4cacc8 into python:master Jul 30, 2019
@bedevere-bot
Copy link

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!

@minho42
Copy link
Contributor Author

minho42 commented Jul 30, 2019

Thanks.

@minho42 minho42 deleted the Fix-some-typos branch July 30, 2019 22:33
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
* Fix typos in comments, docs and test names

* Update test_pyparse.py

account for change in string length

* Apply suggestion: splitable -> splittable

Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu>

* Apply suggestion: splitable -> splittable

Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu>

* Apply suggestion: Dealloccte -> Deallocate

Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu>

* Update posixmodule checksum.

* Reverse idlelib changes.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
* Fix typos in comments, docs and test names

* Update test_pyparse.py

account for change in string length

* Apply suggestion: splitable -> splittable

Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu>

* Apply suggestion: splitable -> splittable

Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu>

* Apply suggestion: Dealloccte -> Deallocate

Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu>

* Update posixmodule checksum.

* Reverse idlelib changes.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
* Fix typos in comments, docs and test names

* Update test_pyparse.py

account for change in string length

* Apply suggestion: splitable -> splittable

Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu>

* Apply suggestion: splitable -> splittable

Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu>

* Apply suggestion: Dealloccte -> Deallocate

Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu>

* Update posixmodule checksum.

* Reverse idlelib changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants