Skip to content

Update ftplib.all_errors documentation to match code #15026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2019
Merged

Update ftplib.all_errors documentation to match code #15026

merged 1 commit into from
Sep 11, 2019

Conversation

lurch
Copy link
Contributor

@lurch lurch commented Jul 30, 2019

The documentation doesn't mention the EOFError that https://github.com/python/cpython/blob/master/Lib/ftplib.py#L66 includes

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jul 30, 2019
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@matrixise matrixise merged commit 51adfc6 into python:master Sep 11, 2019
@bedevere-bot
Copy link

@matrixise: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @lurch for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@lurch @miss-islington
Update ftplib.all_errors documentation to match code (pythonGH-15026)
2a2f2da 
The documentation doesn't mention the `EOFError` that https://github.com/python/cpython/blob/master/Lib/ftplib.pyGH-L66 includes
(cherry picked from commit 51adfc6)

Co-authored-by: Andrew Scheller <github@loowis.durge.org>
@bedevere-bot
Copy link

GH-15960 is a backport of this pull request to the 3.8 branch.

@matrixise
Copy link
Member

Thank you for your contribution to Python. Really appreciated.

miss-islington added a commit that referenced this pull request Sep 11, 2019
@miss-islington @lurch
Update ftplib.all_errors documentation to match code (GH-15026)
2f2a867 
The documentation doesn't mention the `EOFError` that https://github.com/python/cpython/blob/master/Lib/ftplib.pyGH-L66 includes
(cherry picked from commit 51adfc6)

Co-authored-by: Andrew Scheller <github@loowis.durge.org>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@lurch @DinoV
Update ftplib.all_errors documentation to match code (python#15026)
4fa40e5 
The documentation doesn't mention the `EOFError` that https://github.com/python/cpython/blob/master/Lib/ftplib.py#L66 includes
@lurch lurch deleted the patch-1 branch September 16, 2019 12:20
@lurch lurch mentioned this pull request Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lurch @the-knights-who-say-ni @bedevere-bot @miss-islington @matrixise