Allow graceful error handling in messages.py when MIMEText object encodes payload #15147
Conversation
Allow for more graceful encoding when errors are encountered.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
|
Hi @F1uxCapacitor, Thank you for your contribution but
Thank you |
|
Hi Stéphane!
Thank you very much for the response and feedback. For your first item, I signed and submitted my CLA a while back, probably a day or so after I opened the PR. This has been confirmed by the Check Python CLA app, and it actually looks like it was rectified on the PR just 15 minutes ago.
For your second item, I have changed the title of the Pull Request; however, as I made the updates completely in the GitHub browser interface, there is not currently a mechanism to change my commit message via the browser. Please let me know how to proceed.
Again, thank you for your feedback!
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Stéphane Wirtel <notifications@github.com>
Sent: Wednesday, September 11, 2019, 3:30 AM
To: python/cpython
Cc: Taylor Ainsworth; Mention
Subject: Re: [python/cpython] Update message.py (#15147)
Hi @F1uxCapacitor<https://github.com/F1uxCapacitor>,
Thank you for your contribution but
1. Could you sign the CLA as recommended by @the-knights-who-say-ni<https://github.com/the-knights-who-say-ni>
2. Could you change the title of your PR and your commit because the current one is not clear?
Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#15147?email_source=notifications&email_token=AHSQRPFGFOWKT3A53QMW3OTQJCUCDA5CNFSM4IJYSON2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6NWNYI#issuecomment-530278113>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHSQRPHANRMFH46UREEGCPTQJCUCDANCNFSM4IJYSONQ>.
|
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
Should we allow non-conformant (aka potentially broken, malformed, or misdecoded) Unicode texts be sent into the wild? |
|
@F1uxCapacitor, can you please create an issue for this PR? |
|
The following commit authors need to sign the Contributor License Agreement: |
Allow for more graceful encoding when errors are encountered.