Skip to content

gh-82002: IDLE completion namespace fix #15207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-82002: IDLE completion namespace fix #15207

wants to merge 2 commits into from
+17 −4

Conversation

taleinat
Copy link
Contributor

@taleinat taleinat commented Aug 11, 2019 •
edited by terryjreedy
Loading

@taleinat taleinat added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Aug 11, 2019
@taleinat taleinat requested a review from terryjreedy as a code owner August 11, 2019 11:21
@terryjreedy terryjreedy changed the title bpo-37821: IDLE completion namespace fix gh-82002: IDLE completion namespace fix Oct 5, 2022
@terryjreedy terryjreedy mentioned this pull request Oct 5, 2022
Open
iritkatriel
iritkatriel previously requested changes Nov 27, 2022
View reviewed changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@terryjreedy terryjreedy dismissed iritkatriel’s stale review November 28, 2022 02:25

Merge conflicts fixed.

@terryjreedy
Copy link
Member

Merge conflict in autocomplete.py: __init__ parameter tags added for #25708, this adds namespace. Put latter after former because tags passed positionally in editor. Should make both or all 3 keyword-only in separate patch and fix call.

Merge conflict in run.py: changed code made conditional on not testing by #24302, which added tests for respecting excepthook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel left review comments

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Assignees
No one assigned
Labels
awaiting review type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@taleinat @bedevere-bot @terryjreedy @iritkatriel @ambv @the-knights-who-say-ni @ezio-melotti