bpo-38122: minor fixes to AsyncMock spec handling #16099
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
Thanks @voidspace for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Sorry, @voidspace and @matrixise, I could not cleanly backport this to |
|
@voidspace Could you work on the backport for 3.8? Thanks |
…). (cherry picked from commit 14fd925) Co-authored-by: Michael Foord <voidspace@users.noreply.github.com>
|
GH-16137 is a backport of this pull request to the 3.8 branch. |
|
@voidspace I have created a PR with the backport, but I would like to get your approval. |
|
@voidspace: curious as to why these ended up having no tests committed as part of this PR. It's unclear whether https://bugs.python.org/issue38122 is just refactoring or a change in behaviour. If it's the latter, I'd have hoped for some additional tests to verify this... |
Simplification of the spec handling for AsyncMock and correction for how spec_set is handled.
https://bugs.python.org/issue38122