-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-38275: Skip ssl tests for disabled versions #16386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0da9ecd
to
c3fdca3
Compare
test_ssl now handles disabled TLS/SSL versions better. OpenSSL's crypto policy and run-time settings are recognized and tests for disabled versions are skipped. Signed-off-by: Christian Heimes <christian@python.org>
c3fdca3
to
7688b92
Compare
Some platforms / vendors override OpenSSL's defaults with a more strict crypto policy. Make tests accept more minimum versions. Signed-off-by: Christian Heimes <christian@python.org>
7688b92
to
9cba929
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR basically only adds helper function to factorize the code in test_ssl.py, but it doesn't seem to change the behavior. So it looks safe to me.
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
Sorry @tiran, I had trouble checking out the |
Sorry, @tiran, I could not cleanly backport this to |
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Sorry @tiran, I had trouble checking out the |
GH-16425 is a backport of this pull request to the 3.8 branch. |
test_ssl now handles disabled TLS/SSL versions better. OpenSSL's crypto policy and run-time settings are recognized and tests for disabled versions are skipped. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue38275 (cherry picked from commit df6ac7e) Co-authored-by: Christian Heimes <christian@python.org>
GH-16427 is a backport of this pull request to the 3.7 branch. |
test_ssl now handles disabled TLS/SSL versions better. OpenSSL's crypto policy and run-time settings are recognized and tests for disabled versions are skipped. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue38275. (cherry picked from commit df6ac7e) Co-authored-by: Christian Heimes <christian@python.org>
|
|
|
|
|
|
|
|
Check presence of SSLContext.minimum_version to make tests pass with old versions of OpenSSL. Signed-off-by: Christian Heimes <christian@python.org>
|
Check presence of SSLContext.minimum_version to make tests pass with old versions of OpenSSL. Signed-off-by: Christian Heimes <christian@python.org>
Check presence of SSLContext.minimum_version to make tests pass with old versions of OpenSSL. Signed-off-by: Christian Heimes <christian@python.org>
…16425) test_ssl now handles disabled TLS/SSL versions better. OpenSSL's crypto policy and run-time settings are recognized and tests for disabled versions are skipped. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue38275 (cherry picked from commit df6ac7e)
|
test_ssl now handles disabled TLS/SSL versions better. OpenSSL's crypto policy and run-time settings are recognized and tests for disabled versions are skipped. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue38275
Check presence of SSLContext.minimum_version to make tests pass with old versions of OpenSSL. Signed-off-by: Christian Heimes <christian@python.org>
test_ssl now handles disabled TLS/SSL versions better. OpenSSL's crypto
policy and run-time settings are recognized and tests for disabled versions
are skipped.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue38275
Automerge-Triggered-By: @tiran