Skip to content

bpo-37883 - Added a new method doc to threading.Lock().locked() #16420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

bpo-37883 - Added a new method doc to threading.Lock().locked() #16420

wants to merge 5 commits into from

Conversation

idomic
Copy link
Contributor

@idomic idomic commented Sep 26, 2019 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@idomic, @idomazon

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 26, 2019
@idomic idomic changed the title Added a new method doc to threading.Lock().locked() Issue37883 - Added a new method doc to threading.Lock().locked() Sep 26, 2019
@idomic
Copy link
Contributor Author

idomic commented Sep 26, 2019

@taleinat First commit hope I did it well!!

remilapeyre
remilapeyre reviewed Sep 27, 2019
View reviewed changes
Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this patch @idomic, I just made a small suggestion.

@remilapeyre
Copy link
Contributor

BTW, the commit got associated to @idomazon, you will need to sign the CLA with this account as well I think.

@idomic
Update Doc/library/threading.rst
87cd99e 
Accepted comments

Co-Authored-By: Rémi Lapeyre <remi.lapeyre@henki.fr>
@taleinat taleinat changed the title Issue37883 - Added a new method doc to threading.Lock().locked() bpo-37883 - Added a new method doc to threading.Lock().locked() Sep 27, 2019
taleinat
taleinat reviewed Sep 27, 2019
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make this even simpler and shorter, taking the example of Event.is_set(). Something along the lines of "Return True if the lock is currently locked."

@taleinat
Copy link
Contributor

taleinat commented Sep 27, 2019 •
edited
Loading

@idomic, you'll need to resolve the CLA signing issue with your two separate accounts. You may need to create separate bpo accounts, link one to each GitHub account, and sign a CLA agreement once for each account.

@idomic
Copy link
Contributor Author

idomic commented Sep 28, 2019

Shortened the documentation, fixed the signed CLA for the 2nd user.
Should I also merge it with the 3.6 3.7 3.8 branches?

@remilapeyre
Copy link
Contributor

I think a bot will do this automatically based on the tags.

@taleinat
Copy link
Contributor

taleinat commented Sep 28, 2019 •
edited
Loading

@idomic, the current version has diff markings in it; perhaps a merge went wrong?

Regarding backports, as a doc-only improvement, it will go back into 3.8, 3.7 and 2.7. 3.6 is in security-fixes-only status. See the branch status page and the "Branches" section of the development cycle page in the developer's guide for more details.

@deronnax
Copy link
Contributor

deronnax commented Oct 1, 2019

Look at the diff, conflict markers were committed

@idomic
Copy link
Contributor Author

idomic commented Oct 1, 2019

I think it got in somehow because of the GIT GUI.
I've fixed it, sorry for the delay.

@taleinat
Copy link
Contributor

@idomic, the CLA bot is still not happy :(

You need to make sure you have it signed with a bugs.python.org user associated with the @idomazon GitHub account.

This looks good other than that, just waiting to resolve the CLA issue.

@taleinat
Copy link
Contributor

taleinat commented Nov 28, 2019 •
edited
Loading

@idomic, alternatively, you can rebase the PR's branch, re-creating the commits with the email associatied with your @idomic user rather than your @idomazon user.

@idomic idomic closed this Dec 1, 2019
@idomic
Copy link
Contributor Author

idomic commented Dec 1, 2019

Closed this PR and created new on GH-17427

@idomic idomic deleted the documentationRepair branch February 23, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat taleinat left review comments

@remilapeyre remilapeyre remilapeyre left review comments

Assignees
No one assigned
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@idomic @the-knights-who-say-ni @remilapeyre @taleinat @deronnax @bedevere-bot @idomazon