Skip to content

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 30, 2019

Fix the following warning:

modules\_testcapimodule.c(6409):
warning C4146: unary minus operator applied to unsigned type,
result still unsigned

https://bugs.python.org/issue38321

Fix the following warning:

    modules\_testcapimodule.c(6409):
    warning C4146: unary minus operator applied to unsigned type,
    result still unsigned
Copy link
Contributor

@eduardo-elizondo eduardo-elizondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@@ -1952,7 +1952,7 @@ unicode_asutf8andsize(PyObject *self, PyObject *args)
return NULL;
}

buffer = PyUnicode_AsUTF8AndSize(unicode, &utf8_len);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, my editor removes trailing spaces. Trailing spaces must die!

@vstinner vstinner merged commit aca8c40 into python:master Sep 30, 2019
@vstinner vstinner deleted the fix_testcapi_warn branch September 30, 2019 19:14
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
Fix the following warning:

    modules\_testcapimodule.c(6409):
    warning C4146: unary minus operator applied to unsigned type,
    result still unsigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants