Skip to content

[3.7] [3.8] bpo-36670, regrtest: Fix WindowsLoadTracker() for partial line (GH-16550) (GH-16560) #16562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 3, 2019

WindowsLoadTracker.read_output() now uses a short buffer for
incomplete line.

(cherry picked from commit 3e04cd2)

The last line is now passed to the parser even if it does not end
with a newline, but only if it's a valid value.

(cherry picked from commit c65119d)

  • bpo-36670: Enhance regrtest (bpo-36670: regrtest WindowsLoadTracker computes LOAD_FACTOR_1 #16556)

  • Add log() method: add timestamp and load average prefixes
    to main messages.

  • WindowsLoadTracker:

    • LOAD_FACTOR_1 is now computed using SAMPLING_INTERVAL
    • Initialize the load to the arithmetic mean of the first 5 values
      of the Processor Queue Length value (so over 5 seconds), rather
      than 0.0.
    • Handle BrokenPipeError and when typeperf exit.
  • format_duration(1.5) now returns '1.5 sec', rather than
    '1 sec 500 ms'

(cherry picked from commit 098e256)
(cherry picked from commit de3195c)

Co-authored-by: Victor Stinner vstinner@python.org

…ythonGH-16550) (pythonGH-16560)

* bpo-36670, regrtest: Fix WindowsLoadTracker() for partial line (pythonGH-16550)

WindowsLoadTracker.read_output() now uses a short buffer for
incomplete line.

(cherry picked from commit 3e04cd2)

* bpo-36670: Enhance regrtest WindowsLoadTracker (pythonGH-16553)

The last line is now passed to the parser even if it does not end
with a newline, but only if it's a valid value.

(cherry picked from commit c65119d)

* bpo-36670: Enhance regrtest (pythonGH-16556)

* Add log() method: add timestamp and load average prefixes
  to main messages.
* WindowsLoadTracker:

  * LOAD_FACTOR_1 is now computed using SAMPLING_INTERVAL
  * Initialize the load to the arithmetic mean of the first 5 values
    of the Processor Queue Length value (so over 5 seconds), rather
    than 0.0.
  * Handle BrokenPipeError and when typeperf exit.

* format_duration(1.5) now returns '1.5 sec', rather than
  '1 sec 500 ms'

(cherry picked from commit 098e256)
(cherry picked from commit de3195c)

Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit f9016e5 into python:3.7 Oct 3, 2019
@miss-islington miss-islington deleted the backport-de3195c-3.7 branch October 3, 2019 15:44
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants