Skip to content

[2.7] bpo-38235: Correct some arguments names in logging documentation (GH-16571) #16586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

AWhetter
Copy link
Contributor

@AWhetter AWhetter commented Oct 4, 2019

(cherry picked from commit 3142c66)

Co-authored-by: Ashley Whetter AWhetter@users.noreply.github.com

https://bugs.python.org/issue38235

pythonGH-16571).

(cherry picked from commit 3142c66)

Co-authored-by: Ashley Whetter <AWhetter@users.noreply.github.com>
@AWhetter
Copy link
Contributor Author

AWhetter commented Oct 4, 2019

@vsajip I just realised that you removed the Python 2.7 version from the issue before merging, which is why @miss-islington didn't backport. Feel free to decline this if you think it doesn't belong in 2.7.

@brandtbucher
Copy link
Member

brandtbucher commented Oct 4, 2019

What happened here? I don't think #16571 was tagged for backport to 2.7!

In my experience, we don't usually backport documentation to that branch.

@AWhetter AWhetter closed this Oct 4, 2019
@vsajip
Copy link
Member

vsajip commented Oct 4, 2019

I just realised that you removed the Python 2.7 version from the issue before merging, which is why @miss-islington didn't backport.

No, FYI miss-islington only creates backport PRs when a label is explicitly set here - and I didn't set one for 2.7, as 2.7 will be end-of-lifed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants