Skip to content

bpo-32996: Documentation fix-up. #16646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2019
Merged

bpo-32996: Documentation fix-up. #16646

merged 2 commits into from
Oct 10, 2019

Conversation

eirrgang
Copy link
Contributor

@eirrgang eirrgang commented Oct 8, 2019 •
edited by bedevere-bot
Loading

PR #4906 changed the typing.Generic class hierarchy, leaving an
outdated comment in the library reference. User-defined Generic ABCs now
must get a abc.ABCMeta metaclass from something other than typing.Generic
inheritance.

https://bugs.python.org/issue32996

@eirrgang
Documentation update for bpo-32996 fix.
22ec452 
PR python#4906 changed the typing.Generic class hierarchy, leaving an
outdated comment in the library reference. User-defined Generic ABCs now
must get a abc.ABCMeta metaclass from something other than typing.Generic
inheritance.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@eirrgang

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 8, 2019
@eirrgang eirrgang mentioned this pull request Oct 8, 2019
Merged
@eirrgang eirrgang closed this Oct 8, 2019
@eirrgang eirrgang deleted the bpo-32996 branch October 8, 2019 10:37
@eirrgang eirrgang restored the bpo-32996 branch October 8, 2019 10:39
@eirrgang
Copy link
Contributor Author

eirrgang commented Oct 8, 2019

Oops. Accidentally closed the issue by deleting the branch. I've restored the branch and the PR could be reopened. I've filled out the CLA, but the status has not updated yet.

@eirrgang eirrgang reopened this Oct 8, 2019
ilevkivskyi
ilevkivskyi reviewed Oct 8, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank! LG, just one suggestion.

Be sure to add your GitHub account in your b.p.o. account as bot explained. Otherwise it (CLA bot) will not find your signed CLA.

@eirrgang @ilevkivskyi
Update Doc/library/typing.rst
54bb8a6 
Co-Authored-By: Ivan Levkivskyi <levkivskyi@gmail.com>
@eirrgang
Copy link
Contributor Author

eirrgang commented Oct 8, 2019

Be sure to add your GitHub account in your b.p.o. account as bot explained. Otherwise it (CLA bot) will not find your signed CLA.

Signed and submitted a few hours ago. Maybe done tomorrow?

@eirrgang eirrgang requested a review from ilevkivskyi October 10, 2019 09:37
ilevkivskyi
ilevkivskyi approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilevkivskyi ilevkivskyi merged commit d47f0dd into python:master Oct 10, 2019
@miss-islington
Copy link
Contributor

Thanks @eirrgang for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2019
@eirrgang @miss-islington
bpo-32996: Documentation fix-up. (pythonGH-16646)
b2dc4cb 
PR pythonGH-4906 changed the typing.Generic class hierarchy, leaving an
outdated comment in the library reference. User-defined Generic ABCs now
must get a abc.ABCMeta metaclass from something other than typing.Generic
inheritance.
(cherry picked from commit d47f0dd)

Co-authored-by: M. Eric Irrgang <mei2n@virginia.edu>
@bedevere-bot
Copy link

GH-16696 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Thanks @eirrgang for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2019
@eirrgang @miss-islington
bpo-32996: Documentation fix-up. (pythonGH-16646)
e697e88 
PR pythonGH-4906 changed the typing.Generic class hierarchy, leaving an
outdated comment in the library reference. User-defined Generic ABCs now
must get a abc.ABCMeta metaclass from something other than typing.Generic
inheritance.
(cherry picked from commit d47f0dd)

Co-authored-by: M. Eric Irrgang <mei2n@virginia.edu>
@bedevere-bot
Copy link

GH-16697 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 10, 2019
@miss-islington @eirrgang
bpo-32996: Documentation fix-up. (GH-16646)
ca01236 
PR GH-4906 changed the typing.Generic class hierarchy, leaving an
outdated comment in the library reference. User-defined Generic ABCs now
must get a abc.ABCMeta metaclass from something other than typing.Generic
inheritance.
(cherry picked from commit d47f0dd)

Co-authored-by: M. Eric Irrgang <mei2n@virginia.edu>
miss-islington added a commit that referenced this pull request Oct 10, 2019
@miss-islington @eirrgang
bpo-32996: Documentation fix-up. (GH-16646)
baf8a9b 
PR GH-4906 changed the typing.Generic class hierarchy, leaving an
outdated comment in the library reference. User-defined Generic ABCs now
must get a abc.ABCMeta metaclass from something other than typing.Generic
inheritance.
(cherry picked from commit d47f0dd)

Co-authored-by: M. Eric Irrgang <mei2n@virginia.edu>
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Oct 14, 2019
@miss-islington @eirrgang @ned-deily
bpo-32996: Documentation fix-up. (pythonGH-16646)
49e650b 
PR pythonGH-4906 changed the typing.Generic class hierarchy, leaving an
outdated comment in the library reference. User-defined Generic ABCs now
must get a abc.ABCMeta metaclass from something other than typing.Generic
inheritance.
(cherry picked from commit d47f0dd)

Co-authored-by: M. Eric Irrgang <mei2n@virginia.edu>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@eirrgang
bpo-32996: Documentation fix-up. (pythonGH-16646)
a9d9f72 
PR python#4906 changed the typing.Generic class hierarchy, leaving an
outdated comment in the library reference. User-defined Generic ABCs now
must get a abc.ABCMeta metaclass from something other than typing.Generic
inheritance.
@eirrgang eirrgang deleted the bpo-32996 branch April 20, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eirrgang @the-knights-who-say-ni @miss-islington @bedevere-bot @ilevkivskyi