Skip to content

bpo-38425: Remove ‘res’ may be used uninitialized warning #16688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2019
Merged

bpo-38425: Remove ‘res’ may be used uninitialized warning #16688

merged 3 commits into from
Oct 10, 2019

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Oct 10, 2019 •
edited by bedevere-bot
Loading

I' ve noticed this warning on this environment.

Python/Python-ast.c: In function ‘PyAST_obj2mod’:
Python/Python-ast.c:10253:12: warning: ‘res’ may be used uninitialized in this function [-Wmaybe-uninitialized]

CentOS Linux release 7.6.1810
gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36)

https://bugs.python.org/issue38425

@corona10 corona10 requested a review from vstinner October 10, 2019 05:05
@corona10
Copy link
Member Author

@vstinner
As far as I know, you are a RedHat expert.
So I request the review of this PR to you

vstinner
vstinner reviewed Oct 10, 2019
View reviewed changes
@corona10
Copy link
Member Author

@vstinner
I'd like to add backport label 3.8 / 3.7.
What do you think?

@vstinner
Copy link
Member

As far as I know, you are a RedHat expert. So I request the review of this PR to you

This issue is specific to old versions of GCC, not to RHEL/Centos.

@vstinner I'd like to add backport label 3.8 / 3.7. What do you think?

I think that GCC 4.8.5 is stupid and that GCC 9.2.1 on Fedora 30 is smarter: it doesn't emit this false alarm :-) I'm fine with backporting the change to 3.7 and 3.8.

@vstinner vstinner merged commit a05fcd3 into python:master Oct 10, 2019
@miss-islington
Copy link
Contributor

Thanks @corona10 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2019
@corona10 @miss-islington
bpo-38425: Fix ‘res’ may be used uninitialized warning (pythonGH-16688)
44fb518 
(cherry picked from commit a05fcd3)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot
Copy link

GH-16693 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2019
@corona10 @miss-islington
bpo-38425: Fix ‘res’ may be used uninitialized warning (pythonGH-16688)
9367750 
(cherry picked from commit a05fcd3)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot
Copy link

GH-16694 is a backport of this pull request to the 3.7 branch.

@corona10 corona10 deleted the bpo-38425 branch October 10, 2019 07:43
miss-islington added a commit that referenced this pull request Oct 10, 2019
@miss-islington @corona10
bpo-38425: Fix ‘res’ may be used uninitialized warning (GH-16688)
6b6935e 
(cherry picked from commit a05fcd3)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
miss-islington added a commit that referenced this pull request Oct 10, 2019
@miss-islington @corona10
bpo-38425: Fix ‘res’ may be used uninitialized warning (GH-16688)
d27a9b1 
(cherry picked from commit a05fcd3)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@corona10
bpo-38425: Fix ‘res’ may be used uninitialized warning (pythonGH-16688)
d86a43d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni