[WIP] doctest: lazily instantiate debugger #16946
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
commented
Oct 27, 2019
| @@ -1209,6 +1202,8 @@ def __init__(self, checker=None, verbose=None, optionflags=0): | |||
| # Create a fake output target for capturing doctest output. | |||
| self._fakeout = _SpoofOut() | |||
|
|
|||
| self.debugger = None | |||
There was a problem hiding this comment.
self._debugger might be better, but decided to keep it like this for some B/C at least.
blueyed
commented
Oct 27, 2019
|
CI is passing, please let me know if I should continue with it / if there is interest in general. |
9e87d5d to
db8fdb5
Compare
|
The following commit authors need to sign the Contributor License Agreement: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debugger gets instantiated always since a while (2de91ba), but that should not be necessary.
Mainly meant to get test / CI results for now.