Skip to content

bpo-38613: Optimize set operations of dict keys. #16961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 7, 2019
Merged

bpo-38613: Optimize set operations of dict keys. #16961

merged 5 commits into from
Nov 7, 2019

Conversation

methane
Copy link
Member

@methane methane commented Oct 28, 2019 •
edited by bedevere-bot
Loading

@methane methane added performance Performance or resource usage skip news labels Oct 28, 2019
@rhettinger
Copy link
Contributor

+1 This looks like a nice improvement.

@methane methane removed the skip news label Oct 29, 2019
serhiy-storchaka
serhiy-storchaka reviewed Nov 5, 2019
View reviewed changes
Objects/dictobject.c

tmp = _PyObject_CallMethodIdOneArg(result, &PyId_difference_update, other);
_Py_IDENTIFIER(difference_update);
PyObject *tmp = _PyObject_CallMethodIdOneArg(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering whether calling set.difference_update(result, other) using fast call can be faster than calling result.difference_update(other). But this is for other issue.

@methane methane merged commit 6cbc84f into python:master Nov 7, 2019
@methane methane deleted the optimize-dictkeys branch November 7, 2019 15:59
@serhiy-storchaka
Copy link
Member

LGTM. Sorry, forgot to approve the PR.

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@methane
bpo-38613: Optimize set operations of dict keys. (pythonGH-16961)
2718296
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@methane @shihai1991
bpo-38613: Optimize set operations of dict keys. (pythonGH-16961)
cff6704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@rhettinger rhettinger rhettinger approved these changes

Assignees
No one assigned
Labels
performance Performance or resource usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@methane @rhettinger @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot