Skip to content

[WIP] bpo-38806: bdb: stop_here: always stop at calling frame #17159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] bpo-38806: bdb: stop_here: always stop at calling frame #17159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
561d3c1
bpo-38806: bdb: stop_here: always stop at calling frame
blueyed Nov 15, 2019
cc60f41
test
blueyed Nov 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Lib/bdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,10 @@ def is_skipped_module(self, module_name):

def stop_here(self, frame):
"Return True if frame is below the starting frame in the stack."
# (CT) stopframe may now also be None, see dispatch_call.
# (CT) the former test for None is therefore removed from here.
if (self.stopframe is None
and self.returnframe is None
and self.stoplineno == 0): # TEST: via set_step
return True
if self.skip and \
self.is_skipped_module(frame.f_globals.get('__name__')):
return False
Expand Down