Skip to content

Minor Documentation Improvements #17696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 25, 2019
Merged

Conversation

WillAyd
Copy link
Contributor

@WillAyd WillAyd commented Dec 25, 2019

The added parentheses around the PyIter_Next assignment suppress the following warning which gcc throws without:

warning: using the result of an assignment as a condition without parentheses [-Wparentheses]

The other change is a typo fix

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@WillAyd

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@WillAyd
Copy link
Contributor Author

WillAyd commented Dec 25, 2019

Already signed CLA; waiting for it to work its way through the system

@miss-islington
Copy link
Contributor

Thanks @WillAyd for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-17697 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 25, 2019
The added parentheses around the PyIter_Next assignment suppress the following warning which gcc throws without:
```
warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
```
The other change is a typo fix
(cherry picked from commit 5c7ed75)

Co-authored-by: William Ayd <william.ayd@icloud.com>
@bedevere-bot
Copy link

GH-17698 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Sorry, @WillAyd and @benjaminp, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5c7ed7550ec2da16d7679e538fcd7c1a5631811f 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 25, 2019
The added parentheses around the PyIter_Next assignment suppress the following warning which gcc throws without:
```
warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
```
The other change is a typo fix
(cherry picked from commit 5c7ed75)

Co-authored-by: William Ayd <william.ayd@icloud.com>
benjaminp pushed a commit that referenced this pull request Dec 25, 2019
The added parentheses around the PyIter_Next assignment suppress the following warning which gcc throws without:
```
warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
```
The other change is a typo fix.
(cherry picked from commit 5c7ed75)

Co-authored-by: William Ayd <william.ayd@icloud.com>
@bedevere-bot
Copy link

GH-17699 is a backport of this pull request to the 2.7 branch.

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
The added parentheses around the PyIter_Next assignment suppress the following warning which gcc throws without:
```
warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
```
The other change is a typo fix
@WillAyd WillAyd deleted the minor-typos branch November 6, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants