Skip to content

bpo-38599: Deprecate creation of asyncio object when the loop is not running #18195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

bpo-38599: Deprecate creation of asyncio object when the loop is not running #18195

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2941d1e
Deprecate creation of asyncio object when the loop is not running
eamanu Jan 26, 2020
7958de9
Add NEWS
eamanu Jan 26, 2020
976a808
Fix Deprecation Warning message.
eamanu Feb 5, 2020
44fa5f6
Remove change on BoundedSemaphore
eamanu Feb 10, 2020
e486fe4
add test
eamanu Feb 10, 2020
bae5755
Merge branch 'master' into fix-38599
eamanu Feb 11, 2020
18c4ddf
Fix tests
eamanu Feb 16, 2020
dc78f3a
Fix PR according to @aeros comments
eamanu Feb 26, 2020
1bb46a8
Fix according to review comments
eamanu Mar 13, 2020
0ca9f61
remove assertWarns on where is not applied
eamanu Mar 16, 2020
c4afc8f
Update Lib/asyncio/locks.py
eamanu Mar 16, 2020
ec3a6aa
fix grammar error
eamanu Mar 16, 2020
dd6dec3
Remove assertWarns not applied on queues test
eamanu Mar 16, 2020
c5d332a
Merge branch 'fix-38599' of github.com:eamanu/cpython into fix-38599
eamanu Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/asyncio/locks.py 
Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
  • Loading branch information
@eamanu @aeros
eamanu and aeros authored Mar 16, 2020
commit c4afc8f78a8cb15b4c44413c7d7c2c2765d7c1ab
2 changes: 1 addition & 1 deletion Lib/asyncio/locks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def __init__(self, *, loop=None):
if loop is None:
self._loop = events._get_running_loop()
if self._loop is None:
warnings.warn("The creation of asyncio objects outside a running "
warnings.warn("The creation of asyncio objects outside of a running "
"event loop is deprecated as of Python 3.9.",
DeprecationWarning, stacklevel=2)
self._loop = events.get_event_loop()
Expand Down