Skip to content

bpo-38506: Fix the Windows launcher's mishandling of 3.10 #18307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 16, 2020
Merged

bpo-38506: Fix the Windows launcher's mishandling of 3.10 #18307

merged 4 commits into from
Nov 16, 2020

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Feb 2, 2020 •
edited by bedevere-bot
Loading

@ZackerySpytz
Copy link
Contributor Author

This may not be the proper fix.

If this approach is accepted, this PR would still need a news entry.

@zooba
Copy link
Member

zooba commented Feb 2, 2020

@ZackerySpytz Using the API is the best choice, IMHO, but rather than using the "clever" subtraction approach, let's just use direct comparisons and return -1, 0 or 1. This isn't a tight loop, so readability wins over number of steps.

@zooba
Copy link
Member

zooba commented Feb 2, 2020

Oh, we probably also want an invariant or neutral locale rather than the current user locale, as we're sorting our own values rather than user-specified values. I don't remember which constant that would be though.

@serhiy-storchaka serhiy-storchaka requested a review from zooba March 14, 2020 13:53
@csabella
Copy link
Contributor

@ZackerySpytz and @zooba , should this one move ahead now that we're on 3.10?

@csabella
Copy link
Contributor

cc @pablogsal

@pablogsal
Copy link
Member

I think there are still some unresolved aspects raised by @zooba

@ZackerySpytz ZackerySpytz force-pushed the bpo-38506-win-launcher branch from c480d2d to 501bea3 Compare November 16, 2020 04:19
@ZackerySpytz ZackerySpytz marked this pull request as ready for review November 16, 2020 06:02
@ZackerySpytz ZackerySpytz requested a review from a team as a code owner November 16, 2020 06:02
@ZackerySpytz
Copy link
Contributor Author

I have updated the PR.

Unfortunately, Py_UNREACHABLE() cannot be used in PC\launcher.c.

gvanrossum
gvanrossum approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it!

@zooba zooba merged commit f62dad1 into python:master Nov 16, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@ZackerySpytz @adorilson
bpo-38506: Fix the Windows py.exe launcher's misordering of 3.10 (pyt…
da5c47f 
…honGH-18307)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@zooba zooba Awaiting requested review from zooba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ZackerySpytz @zooba @csabella @pablogsal @gvanrossum @the-knights-who-say-ni @bedevere-bot