bpo-39600, IDLE: Remove duplicated font names #18430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the font configuration window, remove duplicated font names.
|
Before, Cantarell is listed 4 times:
After, Cantarell is only shown once:
|
hroncok
approved these changes
Feb 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #18430 +/- ##
=========================================
Coverage 82.11% 82.12%
=========================================
Files 1955 1954 -1
Lines 588949 583604 -5345
Branches 44428 44428
=========================================
- Hits 483624 479258 -4366
+ Misses 95674 94700 -974
+ Partials 9651 9646 -5
Continue to review full report at Codecov.
|
|
I'm at the PyCascades Sprint, and reviewed this PR. This looks good to me merge in. |
|
Thanks @KenanHArik and @hroncok for the reviews. Happy to merge. |
|
Carol, I should have been allowed to review before this was merged. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 10, 2020
In the font configuration window, remove duplicated font names. (cherry picked from commit ed335cf) Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 10, 2020
In the font configuration window, remove duplicated font names. (cherry picked from commit ed335cf) Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 10, 2020
In the font configuration window, remove duplicated font names. (cherry picked from commit ed335cf) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-18441 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 10, 2020
In the font configuration window, remove duplicated font names. (cherry picked from commit ed335cf) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-18442 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Feb 10, 2020
miss-islington
added a commit
that referenced
this pull request
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the font configuration window, remove duplicated font names.
https://bugs.python.org/issue39600