[workflow] Use gcc matcher to make warnings prominent #18567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18567 +/- ##
==========================================
- Coverage 82.15% 82.06% -0.09%
==========================================
Files 1958 1955 -3
Lines 589837 584012 -5825
Branches 44458 44458
==========================================
- Hits 484560 479289 -5271
+ Misses 95636 95101 -535
+ Partials 9641 9622 -19
Continue to review full report at Codecov.
|
|
(closing and re-opening to re-run CI) |
|
Ping @pablogsal @zware Looks like there's no |
|
Thanks for working on this @ammaraskar :) 🎉 |
arun-mani-j
pushed a commit
to arun-mani-j/cpython
that referenced
this pull request
Jul 21, 2020
zware
pushed a commit
that referenced
this pull request
Dec 28, 2020
This makes warnings and errors from the compiler very prominent so this should help prevent warnings from sneaking into the code base and catch them in review. See https://discuss.python.org/t/using-github-problem-matchers-to-catch-warnings-early/4254 for more details You can see a demo of this in action here: https://github.com/ammaraskar/cpython/pull/15/files#diff-9ba2eeca0f254ece0a9df4d7cb68e870 GCC and Sphinx matchers have previously been added in GH-18567 and GH-20325, respectively.
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…H-18532) This makes warnings and errors from the compiler very prominent so this should help prevent warnings from sneaking into the code base and catch them in review. See https://discuss.python.org/t/using-github-problem-matchers-to-catch-warnings-early/4254 for more details You can see a demo of this in action here: https://github.com/ammaraskar/cpython/pull/15/files#diff-9ba2eeca0f254ece0a9df4d7cb68e870 GCC and Sphinx matchers have previously been added in pythonGH-18567 and pythonGH-20325, respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes warnings and errors from the compiler very prominent so this should help prevent warnings from sneaking into the code base and catch them in review.
You can see a demo of this in action here: https://github.com/ammaraskar/cpython/pull/16/files#diff-4d35cf8992b795c5e97e9c8b6167cb34
or in screenshot form:
(This PR is sort of a mirror to #18532 but for the linux builds.)