Skip to content

[3.7] bpo-39382: Avoid dangling object use in abstract_issubclass() (GH-18530) #18606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2020
Merged

[3.7] bpo-39382: Avoid dangling object use in abstract_issubclass() (GH-18530) #18606

merged 1 commit into from
Feb 22, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 22, 2020 •
edited by bedevere-bot
Loading

Hold reference of bases tuple until tuple item is done with, because by
dropping the reference the item may be destroyed.
(cherry picked from commit 1c56f8f)

Co-authored-by: Yonatan Goldschmidt yon.goldschmidt@gmail.com

https://bugs.python.org/issue39382

@Jongy @miss-islington
bpo-39382: Avoid dangling object use in abstract_issubclass() (python…
7b3caa1 
…GH-18530)

Hold reference of __bases__ tuple until tuple item is done with, because by
dropping the reference the item may be destroyed.
(cherry picked from commit 1c56f8f)

Co-authored-by: Yonatan Goldschmidt <yon.goldschmidt@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Feb 22, 2020
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Feb 22, 2020
@miss-islington
Copy link
Contributor Author

@Jongy and @serhiy-storchaka: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 43a0137 into python:3.7 Feb 22, 2020
@miss-islington miss-islington deleted the backport-1c56f8f-3.7 branch February 22, 2020 13:32
@miss-islington
Copy link
Contributor Author

@Jongy and @serhiy-storchaka: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot @Jongy