Skip to content

Give proper credit for figuring out and writing PEP-3118 tests. #18644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2020
Merged

Give proper credit for figuring out and writing PEP-3118 tests. #18644

merged 1 commit into from
Feb 24, 2020

Conversation

skrah
Copy link
Contributor

@skrah skrah commented Feb 24, 2020

No description provided.

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Feb 24, 2020
@python python deleted a comment from codecov bot Feb 24, 2020
@skrah skrah merged commit b942ba0 into python:master Feb 24, 2020
@bedevere-bot
Copy link

@skrah: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @skrah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @skrah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 24, 2020
@skrah @miss-islington
Give proper credit for figuring out and writing PEP-3118 tests. (pyth…
8ce99fe 
…onGH-18644)

(cherry picked from commit b942ba0)

Co-authored-by: Stefan Krah <skrah@bytereef.org>
@bedevere-bot
Copy link

GH-18645 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-18646 is a backport of this pull request to the 3.8 branch.

sthagen added a commit to sthagen/python-cpython that referenced this pull request Feb 24, 2020
@sthagen
Merge pull request #266 from python/master
e229e8a 
Give proper credit for figuring out and writing PEP-3118 tests. (python#18644)
skrah pushed a commit that referenced this pull request Feb 24, 2020
@miss-islington
Give proper credit for figuring out and writing PEP-3118 tests. (GH-1…
45cc9ce 
…8644) (#18646)

(cherry picked from commit b942ba0)

Authored-by: Stefan Krah <skrah@bytereef.org>
skrah pushed a commit that referenced this pull request Feb 24, 2020
@miss-islington
Give proper credit for figuring out and writing PEP-3118 tests. (GH-1…
e349e83 
…8644) (#18645)

(cherry picked from commit b942ba0)

Authored-by: Stefan Krah <skrah@bytereef.org>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Windows7 3.7 has failed when building commit e349e83.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/53/builds/80) and take a look at the build logs.
  4. Check if the failure is related to this commit (e349e83) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/53/builds/80

Summary of the results of the build (if available):

Click to see traceback logs 
remote: Enumerating objects: 5, done.        
remote: Counting objects:  20% (1/5)        
remote: Counting objects:  40% (2/5)        
remote: Counting objects:  60% (3/5)        
remote: Counting objects:  80% (4/5)        
remote: Counting objects: 100% (5/5)        
remote: Counting objects: 100% (5/5), done.        
remote: Total 5 (delta 4), reused 4 (delta 4), pack-reused 0        
From https://github.com/python/cpython
 * branch            3.7        -> FETCH_HEAD
Reset branch '3.7'

The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.7.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals
\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.7.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.7.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals
\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.7.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
Could Not Find D:\cygwin\home\db3l\buildarea\3.7.bolen-windows7\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\cygwin\home\db3l\buildarea\3.7.bolen-windows7\build\PCbuild\python*.zip
The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.7.bolen-windows7\build\PCbuild\\..\externals\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.7.bolen-windows7\build\PCbuild\\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.

test_pty skipped -- No module named 'termios'
test_pwd skipped -- No module named 'pwd'
test_openpty skipped -- os.openpty() not available.
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
minkernel\crts\ucrt\src\appcrt\lowio\write.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
test_ossaudiodev skipped -- No module named 'ossaudiodev'
test_devpoll skipped -- test works only on Solaris OS family
stty: standard input: Inappropriate ioctl for device
test_pipes skipped -- pipes module only works on posix
test_grp skipped -- No module named 'grp'
test_ioctl skipped -- No module named 'fcntl'
test_fork1 skipped -- object <module 'os' from 'D:\\cygwin\\home\\db3l\\buildarea\\3.7.bolen-windows7\\build\\lib\\os.py'> has no attribute 'fork'
test_wait4 skipped -- object <module 'os' from 'D:\\cygwin\\home\\db3l\\buildarea\\3.7.bolen-windows7\\build\\lib\\os.py'> has no attribute 'fork'
minkernel\crts\ucrt\src\appcrt\lowio\write.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
minkernel\crts\ucrt\src\appcrt\lowio\close.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
minkernel\crts\ucrt\src\appcrt\lowio\close.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
test_resource skipped -- No module named 'resource'
test_gdb skipped -- Couldn't find gdb on the path
test_poll skipped -- select.poll not defined
test_multiprocessing_forkserver skipped -- forkserver is not available on Windows
test_epoll skipped -- test works only on Linux 2.6
test_readline skipped -- No module named 'readline'
test_kqueue skipped -- test works only on BSD
test_wait3 skipped -- os.fork not defined
test_fcntl skipped -- No module named 'fcntl'
test_threadsignals skipped -- Can't test signal on win32
test_spwd skipped -- No module named 'spwd'
test_curses skipped -- No module named '_curses'
test_multiprocessing_fork skipped -- fork is not available on Windows
test_syslog skipped -- No module named 'syslog'
test_dbm_gnu skipped -- No module named '_gdbm'
test_crypt skipped -- No module named '_crypt'
test_dbm_ndbm skipped -- No module named '_dbm'
test_xxtestfuzz skipped -- No module named '_xxtestfuzz'
test_nis skipped -- No module named 'nis'
test_posix skipped -- No module named 'posix'

The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.7.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals
\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.7.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.7.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals
\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.7.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
Could Not Find D:\cygwin\home\db3l\buildarea\3.7.bolen-windows7\build\PCbuild\python*.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skrah @bedevere-bot @miss-islington @the-knights-who-say-ni