Skip to content

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 4, 2020

test_subprocess.test_user() now skips the test on an user name if the
user name doesn't exist. For example, skip the test if the user
"nobody" doesn't exist on Linux.

https://bugs.python.org/issue39855

test_subprocess.test_user() now skips the test on an user name if the
user name doesn't exist. For example, skip the test if the user
"nobody" doesn't exist on Linux.
@vstinner
Copy link
Member Author

vstinner commented Mar 4, 2020

cc @gpshead

@mcepl
Copy link
Contributor

mcepl commented Mar 5, 2020

Yeah, that’s better solution.

Copy link
Contributor

@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the most reasonable solution for non-existent users is to simply skip the test.

@vstinner vstinner merged commit f7b5d41 into python:master Mar 5, 2020
@vstinner vstinner deleted the subprocess_nobody branch March 5, 2020 13:29
sthagen added a commit to sthagen/python-cpython that referenced this pull request Mar 5, 2020
bpo-39855: Fix test_subprocess if nobody user doesn't exist (pythonGH-18781)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants