bpo-13487: Use sys.modules.copy() in inspect for thread safety #18786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…afety. `list(sys.modules.items())` was apparently not immune to "dictionary changed size during iteration" errors.
Yhg1s
approved these changes
Mar 5, 2020
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
GH-18787 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 5, 2020
…afety. (pythonGH-18786) `list(sys.modules.items())` was apparently not immune to "dictionary changed size during iteration" errors. Tested internally using an integration test that has run into this a couple of times in the past two years. With this patch applied, the test is no longer flaky. (cherry picked from commit 85cf1d5) Co-authored-by: Gregory P. Smith <gps@google.com>
|
GH-18788 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 5, 2020
…afety. (pythonGH-18786) `list(sys.modules.items())` was apparently not immune to "dictionary changed size during iteration" errors. Tested internally using an integration test that has run into this a couple of times in the past two years. With this patch applied, the test is no longer flaky. (cherry picked from commit 85cf1d5) Co-authored-by: Gregory P. Smith <gps@google.com>
miss-islington
added a commit
that referenced
this pull request
Mar 5, 2020
…afety. (GH-18786) `list(sys.modules.items())` was apparently not immune to "dictionary changed size during iteration" errors. Tested internally using an integration test that has run into this a couple of times in the past two years. With this patch applied, the test is no longer flaky. (cherry picked from commit 85cf1d5) Co-authored-by: Gregory P. Smith <gps@google.com>
miss-islington
added a commit
that referenced
this pull request
Mar 5, 2020
…afety. (GH-18786) `list(sys.modules.items())` was apparently not immune to "dictionary changed size during iteration" errors. Tested internally using an integration test that has run into this a couple of times in the past two years. With this patch applied, the test is no longer flaky. (cherry picked from commit 85cf1d5) Co-authored-by: Gregory P. Smith <gps@google.com>
ned-deily
pushed a commit
that referenced
this pull request
Mar 10, 2020
…afety. (GH-18786) `list(sys.modules.items())` was apparently not immune to "dictionary changed size during iteration" errors. Tested internally using an integration test that has run into this a couple of times in the past two years. With this patch applied, the test is no longer flaky. (cherry picked from commit 85cf1d5) Co-authored-by: Gregory P. Smith <gps@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list(sys.modules.items())was apparently not immune to "dictionarychanged size during iteration" errors.
https://bugs.python.org/issue13487