bpo-27807: Skip test_site.test_startup_imports() if pth file #19060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_site.test_startup_imports() is now skipped if a path of sys.path contains a .pth file. Sort test_site imports.
|
@corona10: Would you mind to review this change? |
I will take a look :) |
corona10
approved these changes
Mar 18, 2020
encukou
reviewed
Mar 18, 2020
Co-Authored-By: Petr Viktorin <encukou@gmail.com>
|
@encukou: woops, nice catch :-) Thanks for the suggestion, I like to just click on a button :-) |
|
I'll test this PR downstream |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-19089 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 20, 2020
vstinner
added a commit
that referenced
this pull request
Mar 20, 2020
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 20, 2020
…ythonGH-19060) (pythonGH-19090) test_site.test_startup_imports() is now skipped if a path of sys.path contains a .pth file. Sort test_site imports. (cherry picked from commit ba26bf3) Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_site.test_startup_imports() is now skipped if a path of sys.path
contains a .pth file.
Sort test_site imports.
https://bugs.python.org/issue27807