gh-83915: Deprecate the readinto() fallback path in _pickle.c #19237
Conversation
|
I think the warning message could be better. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
There was a problem hiding this comment.
With the change the test fails for the Python version unpickler:
======================================================================
FAIL: test_multiple_unpicklings_minimal (test.test_pickle.PyPicklerUnpicklerObjectTests.test_multiple_unpicklings_minimal)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/iritkatriel/src/cpython/Lib/test/pickletester.py", line 3710, in test_multiple_unpicklings_minimal
with self.assertWarns(DeprecationWarning):
AssertionError: DeprecationWarning not triggered
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
All commit authors signed the Contributor License Agreement. |
https://bugs.python.org/issue39734