Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@gotlibsh

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Hi, thanks for this! Definitely worth noting this in the docs.

Have you considered simply adding '0X' to the list in the paragraph describing the '#' modifier? I.e.:

The '#' option causes the “alternate form” to be used for the conversion. [...] For integers, when binary, octal, or hexadecimal output is used, this option adds the prefix respective '0b', '0o', '0x' or '0X' to the output value.

@taleinat Thanks for you input, I didn't consider this option.

On one hand it makes perfect sense to add it where you specified since it's a smaller and simpler change, but on the other hand, I am not sure it's the intuitive location that people will first look at when trying to understand this behavior.

How would you suggest to decide what the right solution is?

I prefer this in the description of the '#' modifier, since it is much more esoteric. Where possible, we should avoid having info about rare edge-cases mixed with info about common cases.

And as a core dev, if you make this change, I'd be happy to merge it :)

I agree with @taleinat 's review.

+1 to adding a change here:

The '#' option causes the “alternate form” to be used for the conversion. [...] For integers, when binary, octal, or hexadecimal output is used, this option adds the prefix respective '0b', '0o', '0x' or '0X' to the output value.

If you keep the current patch that explains about upper casing of "0X" prefix along with rest. that's a good addition too. We don't want to give an impression that a format like "0xDEADBEEF" can be returned when using '{:#X}'.format("deadbeef")

Note that this was closed only due to the renaming of the master branch to main.

I still think that this is a worthy improvement to the docs, but can't re-open this PR due to the original branch having been deleted.

Tal, we could cherry-pick this 12ec96e (I suppose) and create a new PR and merge it.

@orsenthil, I've already created a new PR for this, please see GH-25941.