Skip to content

bpo-40183: AC_COMPILE_IFELSE doesn't work in all cases #19367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jerome-PS
Copy link

@Jerome-PS Jerome-PS commented Apr 4, 2020

Just compiling the symbol sometimes gives a false positive (for example chroot compiles OK), but also linking properly detects the symbol is missing.

https://bugs.python.org/issue40183

Just compiling the symbol sometimes gives a false positive (for example chroot compiles OK), but also linking properly detects the symbol is missing.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Jerome-PS

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@csabella
Copy link
Contributor

@Jerome-PS, please sign the CLA as requested by @the-knights-who-say-ni bot.

@csabella
Copy link
Contributor

@Jerome-PS, without a signed CLA, this PR will be closed.

@csabella csabella added the stale Stale PR or inactive for long period of time. label Jul 20, 2020
@Jerome-PS
Copy link
Author

@Jerome-PS, without a signed CLA, this PR will be closed.

I DID sign the CLA!

@csabella csabella removed the stale Stale PR or inactive for long period of time. label Jul 21, 2020
@csabella
Copy link
Contributor

@Jerome-PS, sorry about that. As you can see, the automated tool isn't able to find it. @brettcannon, on the bug tracker, it shows there is a signed CLA for the GitHub name, but the tool isn't finding it. Would you be able to help? Thanks!

@brettcannon
Copy link
Member

There was an @ sign in the GitHub username on bugs.python.org. I deleted it and everything looks fine.

@csabella
Copy link
Contributor

Thanks Brett!

@furkanonder
Copy link
Contributor

@Jerome-PS Could you resolve the conflicts?

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants