bpo-30567: Fix refleak in sys.getwindowsversion #1940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@segevfiner, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loewis, @tiran and @serhiy-storchaka to be potential reviewers. |
serhiy-storchaka
approved these changes
Jun 4, 2017
serhiy-storchaka
pushed a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jun 6, 2017
(cherry picked from commit 48fb766)
serhiy-storchaka
pushed a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jun 6, 2017
(cherry picked from commit 48fb766)
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 6, 2017
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a ref leak in
sys.getwindowsversiondue to usingPyTuple_Packand forgetting that it increments the ref count of passed in objects. Found here: #1927 (comment).Clearly shows up in
python -m test -R 3:2 test_sys@eryksun