Skip to content

bpo-40149: Implement traverse in _abc._abc_data #19412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2020
Merged

bpo-40149: Implement traverse in _abc._abc_data #19412

merged 1 commit into from
Apr 7, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 7, 2020 •
edited by bedevere-bot
Loading

Implement tp_traverse and tp_clear slots in _abc._abc_data type.

https://bugs.python.org/issue40149

@vstinner
bpo-40149: Implement traverse in _abc._abc_data
5490183 
Implement traverse and clear slots in _abc._abc_data type.
@corona10 corona10 self-requested a review April 7, 2020 16:17
corona10
corona10 approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've checked the patch on my local machine.
If CIs are passed. It is good to go :)

@vstinner vstinner merged commit 9cc3ebd into python:master Apr 7, 2020
@vstinner vstinner deleted the fix_abc branch April 7, 2020 16:36
@shihai1991
Copy link
Member

This PR looks good to me, but I raised this error again after I use this PR, Lol~

$ ./python -m test -R 3:3 test_threading -m test.test_threading.SubinterpThreadingTests.test_threads_join_2
0:00:00 load avg: 0.52 Run tests sequentially
0:00:00 load avg: 0.52 [1/1] test_threading
beginning 6 repetitions
123456
......
test_threading leaked [19, 19, 19] references, sum=57
test_threading leaked [12, 12, 12] memory blocks, sum=36
test_threading failed

== Tests result: FAILURE ==

1 test failed:
    test_threading

Total duration: 773 ms
Tests result: FAILURE

@vstinner
Copy link
Member Author

vstinner commented Apr 7, 2020

This PR looks good to me, but I raised this error again after I use this PR, Lol~

This change doesn't completely fix https://bugs.python.org/issue40149

See https://bugs.python.org/issue40149#msg365913 and https://bugs.python.org/issue40217

@shihai1991
Copy link
Member

This PR looks good to me, but I raised this error again after I use this PR, Lol~

This change doesn't completely fix https://bugs.python.org/issue40149

See https://bugs.python.org/issue40149#msg365913 and https://bugs.python.org/issue40217

Got it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @shihai1991 @corona10 @the-knights-who-say-ni @bedevere-bot