Skip to content

bpo-39481: Add GenericAlias support to ipaddress.py #19418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 10, 2020
Merged

bpo-39481: Add GenericAlias support to ipaddress.py #19418

merged 4 commits into from
Apr 10, 2020

Conversation

isidentical
Copy link
Member

@isidentical isidentical commented Apr 7, 2020 •
edited by miss-islington
Loading

gvanrossum
gvanrossum reviewed Apr 7, 2020
View reviewed changes
@isidentical isidentical requested a review from gvanrossum April 7, 2020 23:08
gvanrossum
gvanrossum approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the comma and land.

@gvanrossum
Copy link
Member

I'll land by hand, so I can fix the commit message.

@gvanrossum gvanrossum changed the title bpo-39481: Generic alias port to ipaddress._BaseNetwork bpo-39481: Add GenericAlias support to ipaddress.py Apr 10, 2020
@gvanrossum gvanrossum merged commit 2fa67df into python:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isidentical @gvanrossum @the-knights-who-say-ni @bedevere-bot