Skip to content

bpo-39481: Generic alias support to mp.ValueProxy, mp.ApplyResult, mp… #19435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Lib/concurrent/futures/_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import logging
import threading
import time
import types

FIRST_COMPLETED = 'FIRST_COMPLETED'
FIRST_EXCEPTION = 'FIRST_EXCEPTION'
Expand Down Expand Up @@ -544,6 +545,8 @@ def set_exception(self, exception):
self._condition.notify_all()
self._invoke_callbacks()

__class_getitem__ = classmethod(types.GenericAlias)

class Executor(object):
"""This is an abstract base class for concrete asynchronous executors."""

Expand Down
3 changes: 3 additions & 0 deletions Lib/concurrent/futures/thread.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import itertools
import queue
import threading
import types
import weakref
import os

Expand Down Expand Up @@ -57,6 +58,8 @@ def run(self):
else:
self.future.set_result(result)

__class_getitem__ = classmethod(types.GenericAlias)


def _worker(executor_reference, work_queue, initializer, initargs):
if initializer is not None:
Expand Down
3 changes: 3 additions & 0 deletions Lib/http/cookies.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@
#
import re
import string
import types

__all__ = ["CookieError", "BaseCookie", "SimpleCookie"]

Expand Down Expand Up @@ -419,6 +420,8 @@ def OutputString(self, attrs=None):
# Return the result
return _semispacejoin(result)

__class_getitem__ = classmethod(types.GenericAlias)


#
# Pattern for finding cookie
Expand Down
3 changes: 3 additions & 0 deletions Lib/multiprocessing/managers.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import array
import queue
import time
import types
import os
from os import getpid

Expand Down Expand Up @@ -1129,6 +1130,8 @@ def set(self, value):
return self._callmethod('set', (value,))
value = property(get, set)

__class_getitem__ = classmethod(types.GenericAlias)


BaseListProxy = MakeProxyType('BaseListProxy', (
'__add__', '__contains__', '__delitem__', '__getitem__', '__len__',
Expand Down
3 changes: 3 additions & 0 deletions Lib/multiprocessing/pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import threading
import time
import traceback
import types
import warnings
from queue import Empty

Expand Down Expand Up @@ -780,6 +781,8 @@ def _set(self, i, obj):
del self._cache[self._job]
self._pool = None

__class_getitem__ = classmethod(types.GenericAlias)

AsyncResult = ApplyResult # create alias -- see #17805

#
Expand Down
3 changes: 3 additions & 0 deletions Lib/multiprocessing/queues.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import threading
import collections
import time
import types
import weakref
import errno

Expand Down Expand Up @@ -366,3 +367,5 @@ def put(self, obj):
else:
with self._wlock:
self._writer.send_bytes(obj)

__class_getitem__ = classmethod(types.GenericAlias)
3 changes: 3 additions & 0 deletions Lib/multiprocessing/shared_memory.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import errno
import struct
import secrets
import types

if os.name == "nt":
import _winapi
Expand Down Expand Up @@ -508,3 +509,5 @@ def index(self, value):
return position
else:
raise ValueError(f"{value!r} not in this container")

__class_getitem__ = classmethod(types.GenericAlias)
13 changes: 12 additions & 1 deletion Lib/test/test_genericalias.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,14 @@
defaultdict, deque, OrderedDict, Counter, UserDict, UserList
)
from collections.abc import *
from concurrent.futures import Future
from concurrent.futures.thread import _WorkItem
from contextlib import AbstractContextManager, AbstractAsyncContextManager
from http.cookies import Morsel
from multiprocessing.managers import ValueProxy
from multiprocessing.pool import ApplyResult
from multiprocessing.shared_memory import ShareableList
from multiprocessing.queues import SimpleQueue
from os import DirEntry
from re import Pattern, Match
from types import GenericAlias, MappingProxyType
Expand Down Expand Up @@ -35,7 +42,11 @@ def test_subscriptable(self):
Mapping, MutableMapping, MappingView,
KeysView, ItemsView, ValuesView,
Sequence, MutableSequence,
MappingProxyType, DirEntry
MappingProxyType, DirEntry,
ValueProxy, ApplyResult,
ShareableList, SimpleQueue,
Future, _WorkItem,
Morsel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing comma.

):
tname = t.__name__
with self.subTest(f"Testing {tname}"):
Expand Down