-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-40366: Remove support for passing obsolete flags into compile #19660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If CO_NESTED is no longer useful, why not removing the flag rather than adding a complicated deprecated code path? Passing flags to compile() is uncommon.
@serhiy-storchaka: Do you think that a deprecation period is needed?
Since how long CO_NESTED does nothing?
|
Oh. If CO_NESTED is useless since Python 2.2 which was released 19 years ago, it's maybe time to remove it. |
Does this removal will cover disallowing |
I don't see any benefit from removing this import: it doesn't reduce the Python maintenance burden, it just breaks existing applications for free. Most
|
@isidentical Could you resolve the conflicts? |
FWIW, removal of |
In that case, I think we can close the PR. @isidentical What are your thoughts on this? |
This PR also removes a case related
CO_GENERATOR_ALLOWED
(which was also unusable, and totally purged in #19230)https://bugs.python.org/issue40366