gh-71807: The escape key closes IDLE's config dialog as canceled #19706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the escape key binding should be enabled, but I'm not so sure about the other ones. |
terryjreedy
reviewed
Sep 18, 2022
There was a problem hiding this comment.
PR title and blurb only refer to Escape to exit (cancel). I may limit PR to this, but expand to subsidiary dialogs that are not query boxes. (Should check code since it works.)
If there is a key for [Apply], there should be a key for [OK].
Ctrl-Enter and Alt-Enter might be a good pair.
Tab navigation has multiple problems: Never gets to these buttons.
Tabbing into font sample traps focus on the text widget.
Some widgets get skipped.
Other key bindings are needed: No way to toggle button or select radio button.
Changes are needed, but I am not sure which to do at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.