Skip to content

bpo-23937: IDLE maximise on load #19816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

bpo-23937: IDLE maximise on load #19816

wants to merge 6 commits into from

Conversation

E-Paine
Copy link
Contributor

@E-Paine E-Paine commented Apr 30, 2020

Windows requires a different mechanism to Linux (the platform I originally developed on). I do not have a MacOS machine so am unable to test on MacOS.
@terryjreedy
Copy link
Member

@Mariatta The knight failed to add CLA labels. It initially said unsigned, now your check app says signed.

@E-Paine
Copy link
Contributor Author

E-Paine commented Apr 30, 2020

@Mariatta The knight failed to add CLA labels. It initially said unsigned, now your check app says signed.

That would be my fault, as my CLA was still pending when I created this request.

@terryjreedy
Copy link
Member

That is OK. The problem is that there was and is no CLA label under labels, on the right.

I am surprised at the zoom issue. I want to check the tk docs. I can write a small tkinter program on my Macbook to see what works there.

E-Paine added 4 commits April 30, 2020 21:05
The "create_page_general" docstring has been updated for the new checkbutton
I have updated the IDLE news to contain brief details of the changes made
I have wrapped the description so that it is not too long
I had repeated the word "for", and so the repeat has been removed
@terryjreedy
Copy link
Member

@vstinner The issue is still open and this PR was still a work in progress. Was closing an accidental side effect of switching to main not working right? How do we reopen?

@vstinner
Copy link
Member

@vstinner The issue is still open and this PR was still a work in progress. Was closing an accidental side effect of switching to main not working right? How do we reopen?

I did nothing. The PR was closed automatically by GitHub when @pablogsal renamed the master branch to main.

I guess that the branch of this PR was removed in the upstream repository. Someone has to recreate the PR.

@terryjreedy
Copy link
Member

@vstinner A few comments above, Github says "vstinner closed this 7 days ago" and "vstinner deleted the branch python:master 7 days ago" Hence my questions. In any case, the answer is 'Yes, there was a glitch somewhere'. Github also misleads when it says, when pausing a mouse over the grayed-out reopen button, that the repository is gone. Only the master branch is gone. In any case, Paine already recreated this as PR 25946, as indicated above, and we can move forward.

@vstinner
Copy link
Member

In any case, Paine already recreated this as PR 25946, as indicated above, and we can move forward.

Cool ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants