Skip to content

bpo-40465: Deprecate the optional argument to random.shuffle(). #19867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 2, 2020

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented May 2, 2020

Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think there is a typo in the warning message.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry in What's New.

Comment on lines 211 to 212
.. deprecated:: 3.9
In the future, the optional argument *random* will be removed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the shuffle() function is deprecated. It should be specified that the argument is deprecated.

You can also use the deprecated-removed directive to specify the version of removing.

rhettinger and others added 4 commits May 2, 2020 15:08
Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@rhettinger rhettinger merged commit 190fac9 into python:master May 2, 2020
@bedevere-bot
Copy link

@rhettinger: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants