Skip to content

gh-84687: Add filename to the error raised by os.exec* #19915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-84687: Add filename to the error raised by os.exec* #19915

wants to merge 5 commits into from

Conversation

russelldavis
Copy link
Contributor

@russelldavis russelldavis commented May 5, 2020 •
edited by bedevere-bot
Loading

remilapeyre
remilapeyre suggested changes Jun 6, 2020
View reviewed changes
Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @russelldavis !

@russelldavis
Copy link
Contributor Author

@remilapeyre thanks for reviewing and approving. What's the next step for getting it merged?

@remilapeyre
Copy link
Contributor

Hi @russelldavis, a core developer will make a second review of your PR and will either merge or ask for some changes. There is not much you can do on your end to speed this up, there is a long backlog of PRs to review and making a good review of each of them take some time but they will get there eventually.

taleinat
taleinat approved these changes Oct 18, 2020
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!

I think the NEWS entry should be slightly re-worded though, see inline comment.

@russelldavis
Copy link
Contributor Author

@taleinat @remilapeyre can we get this merged now? Thanks.

@furkanonder
Copy link
Contributor

LGTM

@russelldavis
Copy link
Contributor Author

@furkanonder thanks for approving the PR. It's been over 3 years now and has 3 approvals. How do we get it merged?

@arhadthedev
Copy link
Member

How do we get it merged?

After the feature freezing 3.12b1 is published next week. Currently core devs implement remaining PEPs and fix bugs introduced by them.

@arhadthedev arhadthedev changed the title bpo-40507: Add filename to the error raised by os.exec* gh-84687: Add filename to the error raised by os.exec* May 15, 2023
@python-cla-bot
Copy link

python-cla-bot bot commented Apr 18, 2025 •
edited
Loading

The following commit authors need to sign the Contributor License Agreement:

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat taleinat approved these changes

@furkanonder furkanonder furkanonder approved these changes

@remilapeyre remilapeyre remilapeyre approved these changes

@larryhastings larryhastings Awaiting requested review from larryhastings

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@russelldavis @remilapeyre @furkanonder @arhadthedev @taleinat @the-knights-who-say-ni @ezio-melotti @bedevere-bot @hauntsaninja