bpo-40561: Provide docstrings for public-facing webbrowser functions #19999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remilapeyre
approved these changes
May 8, 2020
|
cc @birkenfeld |
terryjreedy
approved these changes
May 10, 2020
There was a problem hiding this comment.
Approved with my edits.
@remilapeyre Thank you for the comment. I agree and changed the news item.
@bsolomon1124 I removed the duplication from the open docstring (which you copied from the doc, which I undestand) and made it clearer that autoraise may be ignored either way (which the doc seems to say. I will wait at least a day for you to comment before merging.
|
Thanks for giving this your attention @terryjreedy. Your changes are good by me. |
|
Thanks @bsolomon1124 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 11, 2020
Co-authored-by: Brad Solomon <brsolomon@deloitte.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit ef7973a) Co-authored-by: Brad Solomon <brad.solomon.1124@gmail.com>
|
GH-20036 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 11, 2020
Co-authored-by: Brad Solomon <brsolomon@deloitte.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit ef7973a) Co-authored-by: Brad Solomon <brad.solomon.1124@gmail.com>
|
GH-20037 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
May 11, 2020
miss-islington
added a commit
that referenced
this pull request
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which are open, open_new, and open_new_tab.
https://bugs.python.org/issue40561