Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpo-40503: Add documentation and what's new entry for zoneinfo #20006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-40503: Add documentation and what's new entry for zoneinfo #20006
Changes from all commits
8b10cb3
77e0396
f90eb0c
ea35e5c
02b05da
78576ea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may move this documentation to Doc/using/cmdline.rst, and keep a minimum documention here using the following syntax here to get a link.
By the way, the zoneinfo module should ignore PYTHONTZPATH is sys.flags.ignore_environment is true. See for example
Lib/importlib/_bootstrap_external.py
, since the env var name starts withPYTHON
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you open a BPO issue for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea, but I'd like to save it for a later PR because I don't think I have the time right now to really evaluate and test that change (which is mostly cosmetic / organizational).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I wrote in my approval message, I suggest you to make the PR as it is. My minor remarks can be addressed later (maybe just fix the NEWS entry).