-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
bpo-38323: Temporarily skip close_kill_running() for MultiLoopWatcher in test_asyncio #20013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-38323: Temporarily skip close_kill_running() for MultiLoopWatcher in test_asyncio #20013
Conversation
Oops, that's an easy fix for the windows failure. I should be able to just use |
Co-authored-by: pppery <mapreader@olum.org>
Oh, I hadn't realized that |
@vstinner Would you mind giving this a quick look-over before I merge it? This PR is fairly straightforward since it's just skipping a test, but I'm not quite comfortable yet with merging my own without an approval (particularly with the earlier CI failures). |
Co-authored-by: Chris Jerdonek <chris.jerdonek@gmail.com>
Actually, are you sure that If you look at this comment of @vstinner, it seems like he might be referring to tests other than Either way, it would be important to know if this test was still hanging even with Andrew's change, as that would be a new failure variant. |
@cjerdonek Based on the following comment:
I'm fairly certain that |
That would be great. (In all the times I've reproduced the hang locally, Andrew's change would have prevented it.) |
Closing as the entire |
Note that
@unittest.skipIf()
is not an option here because the child watcher is not set until aftersetUp()
in the mixin.https://bugs.python.org/issue38323