Skip to content

bpo-35114: Make ssl.RAND_status() return a bool (GH-20063) #20063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 23, 2021
Merged

bpo-35114: Make ssl.RAND_status() return a bool (GH-20063) #20063

merged 5 commits into from
Apr 23, 2021
+7 −5

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented May 13, 2020 •
edited
Loading

ssl.RAND_status() returns either 1 or 0.

https://bugs.python.org/issue35114

@ZackerySpytz
bpo-35114: Correct the docs for ssl.RAND_status()
f449b11 
ssl.RAND_status() returns either 1 or 0.
@ZackerySpytz ZackerySpytz requested a review from tiran as a code owner May 13, 2020 01:00
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 13, 2020
@ZackerySpytz
Copy link
Contributor Author

This is a "skip news" PR.

tiran
tiran requested changes May 15, 2020
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the code instead of the documentation. RAND_status() should return a boolean.

The code is in Modules/_ssl.c, use PyBool_FromLong instead PyLong_FromLong, update the doc string, then run make clinic.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ZackerySpytz ZackerySpytz changed the title bpo-35114: Correct the docs for ssl.RAND_status() bpo-35114: Make ssl.RAND_status() return a bool May 17, 2020
@ZackerySpytz
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from tiran May 17, 2020 04:29
@tiran tiran added type-bug An unexpected behavior, bug, or error and removed docs Documentation in the Doc dir labels May 17, 2020
tiran
tiran requested changes May 17, 2020
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add news entry with blurb

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@ZackerySpytz
Copy link
Contributor Author

I originally thought this PR didn't need a news entry.

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from tiran May 19, 2020 03:43
tiran
tiran requested changes Apr 18, 2021
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase the PR and re-generate the clinic file? Thanks!

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@tiran
Copy link
Member

tiran commented Apr 19, 2021

@ZackerySpytz Did you forget to tell Bederver that I have made the requested changes; please review again? This triggers a workflow change and puts the PR back on my plate.

@tiran tiran changed the title bpo-35114: Make ssl.RAND_status() return a bool bpo-35114: Make ssl.RAND_status() return a bool (GH-20063) Apr 23, 2021
@tiran tiran merged commit 7d37b86 into python:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran requested changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZackerySpytz @bedevere-bot @tiran @the-knights-who-say-ni