-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
WIP: PR created to test https://github.com/python/cpython/pull/19983 #20096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We can add an |
@FFY00: Yeah, exactly. I just came up with the same idea :-) It would look better than "Some checks were not successful". Can you propose a PR to fix it? |
Yes, I will do it in a bit. I'll ping you after to rebase this on top of it. |
By the way, usually I wrote |
From what I gathered I think both |
12 seconds, looks good 👌 |
Good: "Tests / Check for source changes (pull_request)" is no longer marked as failed, but "build" jobs continue to be skipped! Sadly, the reason for the skip is not mentioned :-( But it's ok, it's not a big deal. Most people are likely to not bother with it :-) |
Yes, it would be good to be able to provide a reason but I don't really think it's that big of a deal :P As long as the devs are aware of this it should be perfectly fine. |
Ok, great! I confirm that I get a green merge button: I could merge the PR, even with skipped build jobs. Thanks again @FFY00 for fixing our CI config ;-) I now close the issue since it proved that it works. (It doesn't prevent to merge a doc-only PR.) |
No description provided.