Skip to content

WIP: PR created to test https://github.com/python/cpython/pull/19983 #20096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

WIP: PR created to test https://github.com/python/cpython/pull/19983 #20096

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

No description provided.

@FFY00
Copy link
Member

FFY00 commented May 14, 2020

We can add an || true in the end so that github doesn't show the workflow as failed.

@vstinner
Copy link
Member Author

We can add an || true in the end so that github doesn't show the workflow as failed.

@FFY00: Yeah, exactly. I just came up with the same idea :-) It would look better than "Some checks were not successful". Can you propose a PR to fix it?

@FFY00
Copy link
Member

FFY00 commented May 15, 2020

Yes, I will do it in a bit. I'll ping you after to rebase this on top of it.

@vstinner
Copy link
Member Author

By the way, usually I wrote ||: rather than || true. It's an old habit. It's a bash builtin function. I don't know if it's portable. || true sounds more portable :-)

@FFY00
Copy link
Member

FFY00 commented May 15, 2020

From what I gathered I think both : and true are bash builtins. But true is also a POSIX binary (see /usr/bin/true). || true is also more descriptive and doesn't require people to google what : is supposed to do :D

@vstinner
Copy link
Member Author

PR rebased on top of commit 6a78589 (GH-20097).

@ammaraskar
Copy link
Member

12 seconds, looks good 👌

@vstinner
Copy link
Member Author

Good: "Tests / Check for source changes (pull_request)" is no longer marked as failed, but "build" jobs continue to be skipped! Sadly, the reason for the skip is not mentioned :-( But it's ok, it's not a big deal. Most people are likely to not bother with it :-)
https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idif

@FFY00
Copy link
Member

FFY00 commented May 15, 2020

Yes, it would be good to be able to provide a reason but I don't really think it's that big of a deal :P As long as the devs are aware of this it should be perfectly fine.

@vstinner vstinner marked this pull request as ready for review May 15, 2020 02:24
@vstinner
Copy link
Member Author

Ok, great! I confirm that I get a green merge button: I could merge the PR, even with skipped build jobs. Thanks again @FFY00 for fixing our CI config ;-)

I now close the issue since it proved that it works. (It doesn't prevent to merge a doc-only PR.)

@vstinner vstinner closed this May 15, 2020
@vstinner vstinner deleted the test_doc_change branch May 15, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants