Skip to content

bpo-40656: Clean up detect_socket() #20148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2020
Merged

bpo-40656: Clean up detect_socket() #20148

merged 1 commit into from
Nov 18, 2020

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 17, 2020 •
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
Contributor Author

Ref. discussion in #19526, @ned-deily.

@erlend-aasland
Copy link
Contributor Author

@ned-deily would you mind taking a look at this?

ned-deily
ned-deily approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner, thanks. I think we can dispense with a news entry for this.

@ned-deily ned-deily merged commit ccdcb20 into python:master Nov 18, 2020
@erlend-aasland erlend-aasland deleted the fix-issue-40656 branch November 18, 2020 00:13
@erlend-aasland
Copy link
Contributor Author

Thanks for reviewing, @ned-deily !

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@adorilson
bpo-40656: Clean up detect_socket() (pythonGH-20148)
3c9bfa2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @ned-deily @the-knights-who-say-ni @bedevere-bot