Skip to content

bpo-17258: Add requires_hashdigest to multiprocessing tests #20412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2020
Merged

bpo-17258: Add requires_hashdigest to multiprocessing tests #20412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab50fc7
bpo-17258: Add requires_hashdigest to multiprocessing tests
tiran May 26, 2020
763b10d
bpo-17258: Skip concurrent.future multiprocessing test
tiran May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Lib/test/_test_multiprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import test.support
import test.support.script_helper
from test import support
from test.support import hashlib_helper
from test.support import socket_helper


Expand Down Expand Up @@ -2953,6 +2954,8 @@ def test_remote(self):
# Make queue finalizer run before the server is stopped
del queue


@hashlib_helper.requires_hashdigest('md5')
class _TestManagerRestart(BaseTestCase):

@classmethod
Expand Down Expand Up @@ -3437,6 +3440,7 @@ def test_dont_merge(self):
#

@unittest.skipUnless(HAS_REDUCTION, "test needs multiprocessing.reduction")
@hashlib_helper.requires_hashdigest('md5')
class _TestPicklingConnections(BaseTestCase):

ALLOWED_TYPES = ('processes',)
Expand Down Expand Up @@ -3739,6 +3743,7 @@ def test_copy(self):


@unittest.skipUnless(HAS_SHMEM, "requires multiprocessing.shared_memory")
@hashlib_helper.requires_hashdigest('md5')
class _TestSharedMemory(BaseTestCase):

ALLOWED_TYPES = ('processes',)
Expand Down Expand Up @@ -4414,6 +4419,7 @@ def test_invalid_handles(self):



@hashlib_helper.requires_hashdigest('md5')
class OtherTest(unittest.TestCase):
# TODO: add more tests for deliver/answer challenge.
def test_deliver_challenge_auth_failure(self):
Expand Down Expand Up @@ -4450,6 +4456,7 @@ def send_bytes(self, data):
def initializer(ns):
ns.test += 1

@hashlib_helper.requires_hashdigest('md5')
class TestInitializers(unittest.TestCase):
def setUp(self):
self.mgr = multiprocessing.Manager()
Expand Down Expand Up @@ -5302,6 +5309,7 @@ def is_alive(self):
any(process.is_alive() for process in forked_processes))


@hashlib_helper.requires_hashdigest('md5')
class TestSyncManagerTypes(unittest.TestCase):
"""Test all the types which can be shared between a parent and a
child process by using a manager which acts as an intermediary
Expand Down Expand Up @@ -5696,6 +5704,8 @@ def install_tests_in_module_dict(remote_globs, start_method):
Mixin = local_globs[type_.capitalize() + 'Mixin']
class Temp(base, Mixin, unittest.TestCase):
pass
if type_ == 'manager':
Temp = hashlib_helper.requires_hashdigest('md5')(Temp)
Temp.__name__ = Temp.__qualname__ = newname
Temp.__module__ = __module__
remote_globs[newname] = Temp
Expand Down
2 changes: 2 additions & 0 deletions Lib/test/test_concurrent_futures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# Skip tests if sem_open implementation is broken.
support.import_module('multiprocessing.synchronize')

from test.support import hashlib_helper
from test.support.script_helper import assert_python_ok

import contextlib
Expand Down Expand Up @@ -952,6 +953,7 @@ def test_traceback(self):
self.assertIn('raise RuntimeError(123) # some comment',
f1.getvalue())

@hashlib_helper.requires_hashdigest('md5')
def test_ressources_gced_in_workers(self):
# Ensure that argument for a job are correctly gc-ed after the job
# is finished
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2020-05-26-07-53-31.bpo-17258.X_IKTQ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Skip some :mod:`multiprocessing` tests when MD5 hash digest is blocked.