Skip to content

bpo-40833: Clarify docstring of Path.rename #20554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2020
Merged

bpo-40833: Clarify docstring of Path.rename #20554

merged 1 commit into from
Oct 3, 2020

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented May 31, 2020 •
edited
Loading

I made this after I was bitten when assuming Path.rename would take just the new name rather than the full path.

Question: How can I get an automatic backport to 3.8?

https://bugs.python.org/issue40833

@cool-RR cool-RR marked this pull request as ready for review May 31, 2020 14:31
remilapeyre
remilapeyre suggested changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @cool-RR! Should the documentation at Doc/library/pathlib.rst should be updated too?

@cool-RR cool-RR force-pushed the 2020-05-31-pathlib branch from a139180 to c60bb47 Compare June 6, 2020 07:27
@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 6, 2020

Thanks for the feedback. I updated pathlib.rst. I figured I might as well update replace since it's almost the same. In retrospect, it would have be nice if instead of the replace method we just had an exist_ok=False flag on rename, like we do on touch and mkdir.

remilapeyre
remilapeyre suggested changes Jun 10, 2020
View reviewed changes
remilapeyre
remilapeyre approved these changes Jun 21, 2020
View reviewed changes
Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taleinat taleinat added needs backport to 3.8 needs backport to 3.9 only security fixes skip news docs Documentation in the Doc dir labels Oct 2, 2020
@taleinat
Copy link
Contributor

taleinat commented Oct 2, 2020 •
edited
Loading

Question: How can I get an automatic backport to 3.8?

You ask, and then a triager or committer adds the "needs-backport" tag(s). (We'll usually take care of those anyways, though.)

@cool-RR cool-RR force-pushed the 2020-05-31-pathlib branch from fdaee3d to 5124ca7 Compare October 3, 2020 09:27
taleinat
taleinat approved these changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taleinat taleinat merged commit f97e42e into python:master Oct 3, 2020
@miss-islington
Copy link
Contributor

Thanks @cool-RR for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2020
@cool-RR @miss-islington
bpo-40833: Clarify Path.rename doc-string regarding relative paths (p…
68ff18f 
…ythonGH-20554)

(cherry picked from commit f97e42e)

Co-authored-by: Ram Rachum <ram@rachum.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 3, 2020
@bedevere-bot
Copy link

GH-22514 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2020
@cool-RR @miss-islington
bpo-40833: Clarify Path.rename doc-string regarding relative paths (p…
114830f 
…ythonGH-20554)

(cherry picked from commit f97e42e)

Co-authored-by: Ram Rachum <ram@rachum.com>
@bedevere-bot
Copy link

GH-22515 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 3, 2020
@miss-islington @cool-RR
bpo-40833: Clarify Path.rename doc-string regarding relative paths (G…
4b982e0 
…H-20554)

(cherry picked from commit f97e42e)

Co-authored-by: Ram Rachum <ram@rachum.com>
@taleinat taleinat added the needs backport to 3.9 only security fixes label Oct 3, 2020
@miss-islington
Copy link
Contributor

Thanks @cool-RR for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2020
@cool-RR @miss-islington
bpo-40833: Clarify Path.rename doc-string regarding relative paths (p…
a1764fc 
…ythonGH-20554)

(cherry picked from commit f97e42e)

Co-authored-by: Ram Rachum <ram@rachum.com>
@bedevere-bot
Copy link

GH-22516 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 3, 2020
taleinat pushed a commit that referenced this pull request Oct 3, 2020
@miss-islington @cool-RR
[3.9] bpo-40833: Clarify Path.rename doc-string regarding relative pa…
ef7b937 
…ths (GH-20554)

(cherry picked from commit f97e42e)

Co-authored-by: Ram Rachum <ram@rachum.com>
ambv pushed a commit to ambv/cpython that referenced this pull request Oct 4, 2020
@miss-islington @cool-RR @ambv
[3.9] bpo-40833: Clarify Path.rename doc-string regarding relative pa…
5533c49 
…ths (pythonGH-20554)

(cherry picked from commit f97e42e)

Co-authored-by: Ram Rachum <ram@rachum.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@cool-RR
bpo-40833: Clarify Path.rename doc-string regarding relative paths (p…
47e1b4c 
…ythonGH-20554)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat taleinat approved these changes

@remilapeyre remilapeyre remilapeyre approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cool-RR @taleinat @miss-islington @bedevere-bot @remilapeyre @the-knights-who-say-ni