Skip to content

bpo-40636: Documentation for zip-strict #20961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 19, 2020
Merged

bpo-40636: Documentation for zip-strict #20961

merged 7 commits into from
Jun 19, 2020

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Jun 18, 2020 •
edited by bedevere-bot
Loading

@brandtbucher @vstinner @gvanrossum

This is the documentation for the zip-strict feature implemented in #20921 .

When reviewing this PR, I suggest that you look at it in the HTML view.

Also, can someone put the skip-news tag here? There's a news item in the other PR.

https://bugs.python.org/issue40636

@cool-RR cool-RR marked this pull request as ready for review June 18, 2020 11:46
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 18, 2020
@cool-RR cool-RR force-pushed the 2020-06-18-zip-strict-docs branch 2 times, most recently from 709b0b4 to 8dc14f5 Compare June 18, 2020 12:07
@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 18, 2020

Please ignore the docs CI failure here, it's because the feature is implemented in a separate PR.

gvanrossum
gvanrossum reviewed Jun 18, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this first draft! I ran out of time to review the three big bullets more carefully, but I have saved up some feedback that I hope you will take into account.

brandtbucher
brandtbucher reviewed Jun 18, 2020
View reviewed changes
brandtbucher
brandtbucher reviewed Jun 18, 2020
View reviewed changes
brandtbucher
brandtbucher reviewed Jun 18, 2020
View reviewed changes
brandtbucher
brandtbucher reviewed Jun 18, 2020
View reviewed changes
brandtbucher
brandtbucher reviewed Jun 18, 2020
View reviewed changes
brandtbucher
brandtbucher reviewed Jun 18, 2020
View reviewed changes
brandtbucher
brandtbucher reviewed Jun 18, 2020
View reviewed changes
brandtbucher
brandtbucher requested changes Jun 18, 2020
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some comments too.

@cool-RR cool-RR force-pushed the 2020-06-18-zip-strict-docs branch 2 times, most recently from 10cc1c6 to 06408a4 Compare June 18, 2020 20:48
brandtbucher
brandtbucher requested changes Jun 18, 2020
View reviewed changes
gvanrossum
gvanrossum reviewed Jun 19, 2020
View reviewed changes
brandtbucher
brandtbucher requested changes Jun 19, 2020
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, after you apply Guido's feedback. Just one more tiny thing I noticed (not a big deal):

gvanrossum
gvanrossum approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll merge next. Thanks for doing this extensive update!

@gvanrossum
Copy link
Member

Hm, I can't merge because of the failing test. @cool-RR can you merge the latest master now that the implementation has been merged?

@brandtbucher
Copy link
Member

Thanks @cool-RR!

cool-RR and others added 4 commits June 19, 2020 21:40
@cool-RR cool-RR force-pushed the 2020-06-18-zip-strict-docs branch from f21ad5b to a67f52a Compare June 19, 2020 18:41
@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 19, 2020

Rebased and pushed, let's see whether tests pass. I haven't squashed the commits, I assume the GitHub interface lets you do that. If you want me to squash, let me know.

@gvanrossum gvanrossum merged commit 59cf853 into python:master Jun 19, 2020
@bedevere-bot
Copy link

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@gvanrossum
Copy link
Member

gvanrossum commented Jun 19, 2020 •
edited
Loading

Congrats, and thanks! Looking forward to more of your work.

@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 19, 2020

😊

Do you want a PR to the Python 3.10 release schedule?

@gvanrossum
Copy link
Member

gvanrossum commented Jun 19, 2020 via email

@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 19, 2020

I checked for PEPs with the string "Python-Version: 3.10" and besides 618, there isn't a single one that has "Status: Accepted", so I guess not.

fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@cool-RR @fasihahmad
bpo-40636: Documentation for zip-strict (python#20961)
36ba8ab
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@cool-RR @arun-mani-j
bpo-40636: Documentation for zip-strict (python#20961)
47144e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher requested changes

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cool-RR @gvanrossum @brandtbucher @bedevere-bot @the-knights-who-say-ni