[3.7] bpo-40824: Do not mask errors in __iter__ in "in" and the operator module. (GH-20537) #21045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule. (pythonGH-20537) Unexpected errors in calling the __iter__ method are no longer masked by TypeError in the "in" operator and functions operator.contains(), operator.indexOf() and operator.countOf(). (cherry picked from commit cafe1b6) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
@serhiy-storchaka: Status check is done, and it's a success ✅ . |
1 similar comment
|
@serhiy-storchaka: Status check is done, and it's a success ✅ . |
serhiy-storchaka
approved these changes
Jun 22, 2020
|
Sorry, I can't merge this PR. Reason: |
|
As announced, with the tagging of 3.7.8rc1, the 3.7 branch is now in security-fix mode. Should we be making this last-minute change in 3.7 behavior? It doesn't really feel like a big security issue; has anyone reported this problem in the field? I'm reluctant to throw this change in at the last minute but if you can get another core developer to review and approve it, I'll consider it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unexpected errors in calling the iter method are no longer
masked by TypeError in the "in" operator and functions
operator.contains(), operator.indexOf() and operator.countOf().
(cherry picked from commit cafe1b6)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com
https://bugs.python.org/issue40824